From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49DB9C4CEC4 for ; Mon, 23 Sep 2019 16:42:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 211C72168B for ; Mon, 23 Sep 2019 16:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569256937; bh=j5r+6XuhjKJ1Z8KYz75Xk8jUl3r/TVx0tgV4XM0YVoc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ZDGrsvalKrplxECNQqQcGzaZ7UmM6FzkUKfCz5WUyivIjCqqzCW5W6MkaFAxWHxs+ Eb+ouIrmoMXMrieDbBs4nv9PM9qs9mXW5T3zQ/WGwtGgeqUFyK+ePyS2PdQqkYl2St LMuWUTVX4jFupi/iQiqr8DTnJPvon8Gpay/PEajk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390506AbfIWQmQ (ORCPT ); Mon, 23 Sep 2019 12:42:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:46564 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387922AbfIWQmQ (ORCPT ); Mon, 23 Sep 2019 12:42:16 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 205BE2089F; Mon, 23 Sep 2019 16:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569256935; bh=j5r+6XuhjKJ1Z8KYz75Xk8jUl3r/TVx0tgV4XM0YVoc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BM8BOxMf68g4/WepglhG7a6pSQuN8RN85YMHAzOefxueUHAVZ/fiH6QQprzfTnkz2 LGy7vYg8B5O26OnxkQlQzeXwD2PDZHOHdyeyVl51XR9UTMfxwljrdjT8FBMEK9eSoZ N0jb+C4Bs0L6Q1vlVvZ2qByx/J7SR1qer2bfz4No= Date: Mon, 23 Sep 2019 12:42:14 -0400 From: Sasha Levin To: Takashi Iwai Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.2 072/185] ALSA: hda: Add codec on bus address table lately Message-ID: <20190923164213.GG8171@sasha-vm> References: <20190922184924.32534-1-sashal@kernel.org> <20190922184924.32534-72-sashal@kernel.org> <20190923133025.GE8171@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2019 at 03:40:45PM +0200, Takashi Iwai wrote: >On Mon, 23 Sep 2019 15:30:25 +0200, >Sasha Levin wrote: >> >> On Sun, Sep 22, 2019 at 09:06:12PM +0200, Takashi Iwai wrote: >> >On Sun, 22 Sep 2019 20:47:30 +0200, >> >Sasha Levin wrote: >> >> >> >> From: Takashi Iwai >> >> >> >> [ Upstream commit ee5f85d9290fe25d460bd320b7fe073075d72d33 ] >> >> >> >> The call of snd_hdac_bus_add_device() is needed only for registering >> >> the codec onto the bus caddr_tbl[] that is referred essentially only >> >> in the unsol event handler. That is, the reason of this call and the >> >> release by the counter-part function snd_hdac_bus_remove_device() is >> >> just to assure that the unsol event gets notified to the codec. >> >> >> >> But the current implementation of the unsol notification wouldn't work >> >> properly when the codec is still in a premature init state. So this >> >> patch tries to work around it by delaying the caddr_tbl[] registration >> >> at the point of snd_hdac_device_register(). >> >> >> >> Also, the order of snd_hdac_bus_remove_device() and device_del() calls >> >> are shuffled to make sure that the unsol event is masked before >> >> deleting the device. >> >> >> >> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204565 >> >> Signed-off-by: Takashi Iwai >> >> Signed-off-by: Sasha Levin >> > >> >The upstream commit was reverted later by 246bb4aaa4f4, which has even >> >Fixes tag pointing this. So please drop this. >> >> I'll drop it, thank you. >> >> >BTW, this is the second time AUTOSEL overlooked the existing revert. >> >I'm afraid something is missing in the check. >> >> Usually it's the case that I check for fixes/reverts once I compile the >> series, and again right before I queue it up to a stable tree. In >> between fixes and reverts tend to sneak in just like in this case. >> >> In general, I also check the -rcs for fixes and reverts during their >> review window, so while sometimes we send out mails with patches that >> have a fix or revert upstream, they rarely make it into a released >> stable kernel. > >IMO, it'd be great if you have some check before sending for reviews. >The Fixes tag chain can be parsed relatively easily, after all. True. I'll update my scripts to do that. -- Thanks, Sasha