From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E15FC4CECF for ; Mon, 23 Sep 2019 17:31:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 648F020640 for ; Mon, 23 Sep 2019 17:31:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440175AbfIWRbN (ORCPT ); Mon, 23 Sep 2019 13:31:13 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:40234 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437821AbfIWRbN (ORCPT ); Mon, 23 Sep 2019 13:31:13 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 3E7FF20042; Mon, 23 Sep 2019 19:31:08 +0200 (CEST) Date: Mon, 23 Sep 2019 19:31:06 +0200 From: Sam Ravnborg To: Sandy Huang Cc: dri-devel@lists.freedesktop.org, Boris Brezillon , David Airlie , Daniel Vetter , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 22/36] drm/atmel-hlcdc: use bpp instead of cpp for drm_format_info Message-ID: <20190923173106.GA13649@ravnborg.org> References: <1569243119-183293-1-git-send-email-hjc@rock-chips.com> <1569243119-183293-2-git-send-email-hjc@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1569243119-183293-2-git-send-email-hjc@rock-chips.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=s8YR1HE3AAAA:8 a=GZYic5qFh62CaahH_tAA:9 a=CjuIK1q_8ugA:10 a=jGH_LyMDp9YhSvY-UuyI:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sandy. Thanks for taking care of this, but... On Mon, Sep 23, 2019 at 08:51:45PM +0800, Sandy Huang wrote: > cpp[BytePerPlane] can't describe the 10bit data format correctly, > So we use bpp[BitPerPlane] to instead cpp. > > Signed-off-by: Sandy Huang > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > index 89f5a75..ab7d423 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > @@ -644,7 +644,7 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p, > int xdiv = i ? fb->format->hsub : 1; > int ydiv = i ? fb->format->vsub : 1; > > - state->bpp[i] = fb->format->cpp[i]; > + state->bpp[i] = fb->format->bpp[i] / 8; > if (!state->bpp[i]) > return -EINVAL; Awaiting conclusion on Daniels comment on PATCH 1 and has dropped this patch for now. And please address the concerns Rob has about bisectability in your cover letter for v2. Sam