From: Daniel Wagner <dwagner@suse.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: qla2xxx-upstream@qlogic.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Himanshu Madhani <hmadhani@marvell.com>
Subject: Re: WARN_ON_ONCE in qla2x00_status_cont_entry
Date: Thu, 26 Sep 2019 09:55:30 +0200 [thread overview]
Message-ID: <20190926075530.xzjpa733sw3ykr6g@beryllium.lan> (raw)
In-Reply-To: <2e47b106-12d7-908a-857f-3908336f2e1f@acm.org>
On Wed, Sep 25, 2019 at 06:33:35PM -0700, Bart Van Assche wrote:
> On 2019-09-25 05:39, Daniel Wagner wrote:
> > So I after starring on the code I am not sure if the WARN_ON_ONCE is
> > correct. It assumes that after processing one status continuation,
> > there is no more work. Though it looks like there is another element
> > to process. Is it possible that two sense continuation are possible?
>
> According to the firmware documentation it is possible that multiple
> status continuations are emitted by the firmware. Do you want to submit
> a patch or do you prefer that I do this myself?
I just send out a patch, which removes the WARN_ON_ONCE. This solves
the obvious warning but drops the consistency check. Maybe
qla2x00_status_cont_entry() could return a status and the outer loop
could check at the end if sp->done() has been called. But I suppose
this should be done for all parsing functions not just for one.
prev parent reply other threads:[~2019-09-26 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 12:39 WARN_ON_ONCE in qla2x00_status_cont_entry Daniel Wagner
2019-09-26 1:33 ` Bart Van Assche
2019-09-26 7:55 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926075530.xzjpa733sw3ykr6g@beryllium.lan \
--to=dwagner@suse.de \
--cc=bvanassche@acm.org \
--cc=hmadhani@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=qla2xxx-upstream@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).