From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80FBDC4360C for ; Thu, 26 Sep 2019 16:18:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5837B21D56 for ; Thu, 26 Sep 2019 16:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727458AbfIZQS3 (ORCPT ); Thu, 26 Sep 2019 12:18:29 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:50335 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727239AbfIZQS3 (ORCPT ); Thu, 26 Sep 2019 12:18:29 -0400 X-Originating-IP: 83.56.35.30 Received: from localhost (30.red-83-56-35.staticip.rima-tde.net [83.56.35.30]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 5B8911BF203; Thu, 26 Sep 2019 16:18:26 +0000 (UTC) Date: Thu, 26 Sep 2019 18:18:25 +0200 From: Alexandre Belloni To: Markus Elfring Cc: Andrew Lunn , netdev@vger.kernel.org, Florian Fainelli , "David S. Miller" , Heiner Kallweit , LKML , kernel-janitors@vger.kernel.org Subject: Re: [1/2] net/phy/mdio-mscc-miim: Use devm_platform_ioremap_resource() in mscc_miim_probe() Message-ID: <20190926161825.GB6825@piout.net> References: <189ccfc3-d5a6-79fd-29b8-1f7140e9639a@web.de> <506889a6-4148-89f9-302e-4be069595bb4@web.de> <20190920190908.GH3530@lunn.ch> <121e75c5-4d45-9df2-a471-6997a1fb3218@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <121e75c5-4d45-9df2-a471-6997a1fb3218@web.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/09/2019 17:29:02+0200, Markus Elfring wrote: > >> Simplify this function implementation by using a known wrapper function. > … > > Reviewed-by: Andrew Lunn > > Does this feedback indicate also an agreement for the detail > if the mapping of internal phy registers would be a required operation? > (Would such a resource allocation eventually be optional?) It is optional. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com