From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to avoid data corruption by forbidding SSR overwrite
Date: Thu, 26 Sep 2019 14:46:53 -0700 [thread overview]
Message-ID: <20190926214653.GA29685@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <20190926203755.GA142676@gmail.com>
On 09/26, Eric Biggers wrote:
> On Fri, Aug 16, 2019 at 11:03:34AM +0800, Chao Yu wrote:
> > There is one case can cause data corruption.
> >
> > - write 4k to fileA
> > - fsync fileA, 4k data is writebacked to lbaA
> > - write 4k to fileA
> > - kworker flushs 4k to lbaB; dnode contain lbaB didn't be persisted yet
> > - write 4k to fileB
> > - kworker flush 4k to lbaA due to SSR
> > - SPOR -> dnode with lbaA will be recovered, however lbaA contains fileB's
> > data
> >
> > One solution is tracking all fsynced file's block history, and disallow
> > SSR overwrite on newly invalidated block on that file.
> >
> > However, during recovery, no matter the dnode is flushed or fsynced, all
> > previous dnodes until last fsynced one in node chain can be recovered,
> > that means we need to record all block change in flushed dnode, which
> > will cause heavy cost, so let's just use simple fix by forbidding SSR
> > overwrite directly.
> >
> > Signed-off-by: Chao Yu <yuchao0@huawei.com>
> > ---
> > fs/f2fs/segment.c | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> > index 9d9d9a050d59..69b3b553ee6b 100644
> > --- a/fs/f2fs/segment.c
> > +++ b/fs/f2fs/segment.c
> > @@ -2205,9 +2205,11 @@ static void update_sit_entry(struct f2fs_sb_info *sbi, block_t blkaddr, int del)
> > if (!f2fs_test_and_set_bit(offset, se->discard_map))
> > sbi->discard_blks--;
> >
> > - /* don't overwrite by SSR to keep node chain */
> > - if (IS_NODESEG(se->type) &&
> > - !is_sbi_flag_set(sbi, SBI_CP_DISABLED)) {
> > + /*
> > + * SSR should never reuse block which is checkpointed
> > + * or newly invalidated.
> > + */
> > + if (!is_sbi_flag_set(sbi, SBI_CP_DISABLED)) {
> > if (!f2fs_test_and_set_bit(offset, se->ckpt_valid_map))
> > se->ckpt_valid_blocks++;
> > }
> > --
>
> FYI, this commit caused xfstests generic/064 to start failing:
Yup, I was looking at this.
>
> $ kvm-xfstests -c f2fs generic/064
> ...
> generic/064 3s ... [13:36:37][ 5.946293] run fstests generic/064 at 2019-09-26 13:36:37
> [13:36:41]- output mismatch (see /results/f2fs/results-default/generic/064.out.bad)
> --- tests/generic/064.out 2019-09-18 04:53:46.000000000 -0700
> +++ /results/f2fs/results-default/generic/064.out.bad 2019-09-26 13:36:41.533018683 -0700
> @@ -1,2 +1,3 @@
> QA output created by 064
> Extent count after inserts is in range
> +extents mismatched before = 1 after = 50
> ...
> (Run 'diff -u /root/xfstests/tests/generic/064.out /results/f2fs/results-default/generic/064.out.bad' to see the entire diff)
> Ran: generic/064
> Failures: generic/064
> Failed 1 of 1 tests
next prev parent reply other threads:[~2019-09-26 21:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 3:03 [PATCH] f2fs: fix to avoid data corruption by forbidding SSR overwrite Chao Yu
2019-08-19 6:30 ` Chao Yu
2019-08-20 1:00 ` Jaegeuk Kim
2019-08-20 9:16 ` Chao Yu
2019-09-26 20:37 ` [f2fs-dev] " Eric Biggers
2019-09-26 21:46 ` Jaegeuk Kim [this message]
2019-09-27 0:32 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926214653.GA29685@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).