From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4292C352AB for ; Fri, 27 Sep 2019 10:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC4732146E for ; Fri, 27 Sep 2019 10:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569580231; bh=+fEo4fUEQJViks6u8Y2NuprlrpyQm4unKv3q+CwkHlI=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=dUCL509XFrV/51MrMsNY7vdYSyzEerDsL+VBcRnSVbmICAtWnY5KEP3jNxArNrjWF tr6izN2+yn72MbS+Ok+Nyj6VnYQ3fQtNXplsbRgMn8L4YsZB7W23ga/wgPo1PiMHfZ 9v8dUZbwznPtT/xyEV3axc2tbKiVUHgEL+YccyJM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727160AbfI0Kab (ORCPT ); Fri, 27 Sep 2019 06:30:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:56648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbfI0Kaa (ORCPT ); Fri, 27 Sep 2019 06:30:30 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13445217D7; Fri, 27 Sep 2019 10:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569580230; bh=+fEo4fUEQJViks6u8Y2NuprlrpyQm4unKv3q+CwkHlI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=s5svGLLoRmdaFRzXQv2J8lTL0WzQM68UpgEzH+elq1xQhE38OTqe/KsrPlfW4Zn8G 01tecBEmRtPW0Bk1CrVrvg2QqBDhTq6iGiMlP+pfNyf//ccfrh/uxXOVhWIjLWykF/ 0v4xSa/RmRlDavR3c1LpfGXaAwR4zkMFlWrSxg14= Date: Fri, 27 Sep 2019 05:30:28 -0500 From: Bjorn Helgaas To: Kuppuswamy Sathyanarayanan Cc: Ashok Raj , Keith Busch , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 0/5] Fix PF/VF dependency issue Message-ID: <20190927103028.GA21650@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190905193146.90250-1-helgaas@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 05, 2019 at 02:31:41PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > The current implementation of ATS, PASID, and PRI does not handle VF > dependencies correctly. These are essentially Kuppuswamy's patches; I > reordered and tweaked them slightly. > > Please treat this as a proposal, not a done deal, and post a v9 with any > changes needed. > > Changes since v7: > * Moved PRI & PASID capability offset caching to last since they're just > optimizations > * Cached offsets at first use instead of adding _init() functions > * Dropped complicated pci_prg_resp_pasid_required() #ifdefs by just > searching for the capability again > * Dropped EA/VF validation since it only enforces spec language without > fixing any known issues > > Changes since v6: > * Removed locking interfaces used in v6. > * Made necessary changes to PRI/PASID enable/disable calls to allow > register changes only for PF. > > Changes since v5: > * Created new patches for PRI/PASID capability caching. > * Removed individual locks (pri_lock, pasid_lock) and added common > resource lock to synchronize PRI/PASID updates between PF/VF. > * Addressed comments from Bjorn Helgaas. > > Changes since v4: > * Defined empty functions for pci_pri_init() and pci_pasid_init() for cases > where CONFIG_PCI_PRI and CONFIG_PCI_PASID are not enabled. > > Changes since v3: > * Fixed critical path (lock context) in pci_restore_*_state functions. > > Changes since v2: > * Added locking mechanism to synchronize accessing PF registers in VF. > * Removed spec compliance checks in patches. > * Addressed comments from Bjorn Helgaas. > > Changes since v1: > * Added more details about the patches in commit log. > * Removed bulk spec check patch. > * Addressed comments from Bjorn Helgaas. > > > Link: https://lore.kernel.org/r/cover.1567029860.git.sathyanarayanan.kuppuswamy@linux.intel.com v7 > > Kuppuswamy Sathyanarayanan (5): > PCI/ATS: Handle sharing of PF PRI Capability with all VFs > PCI/ATS: Handle sharing of PF PASID Capability with all VFs > PCI/ATS: Disable PF/VF ATS service independently > PCI/ATS: Cache PRI Capability offset > PCI/ATS: Cache PASID Capability offset > > drivers/pci/ats.c | 153 +++++++++++++++++++++++++++----------------- > include/linux/pci.h | 3 +- > 2 files changed, 96 insertions(+), 60 deletions(-) Applied to pci/virtualization for v5.5.