From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A14C4360C for ; Sat, 28 Sep 2019 07:57:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6C912082F for ; Sat, 28 Sep 2019 07:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569657420; bh=g25bV1WdxtGU+b3JNxNBVCRry5AkbtKwGhn0cs1fGLU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=V0Kh0yxM5nWFzHduspzZaNLXHL3/IUEwYr3SVbY1tOeDeChjzWmHGXT5chpRRc7CE 2NC3k7+w/Pi15nqFg38FsZYFQ8mSPMFnBYnPQjLs/NGlYQRuijPhvXAEcQ4PF3360s mfi2adzpHbTaIKgnhsaKH4DtsQlThG0avKAG/8Vo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726224AbfI1H47 (ORCPT ); Sat, 28 Sep 2019 03:56:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:43660 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbfI1H46 (ORCPT ); Sat, 28 Sep 2019 03:56:58 -0400 Received: from devnote2 (unknown [12.157.10.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 985742081B; Sat, 28 Sep 2019 07:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569657418; bh=g25bV1WdxtGU+b3JNxNBVCRry5AkbtKwGhn0cs1fGLU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g7nhWH+H83f3brhv8F25SCu2TcqFjtMqFsgCFXzZsnnP8fst0uJQAtqSHnzmycLyN /xoMe/qM3+UH2ZqQ1MpOkEx5U7GLIGlnoZ+84M/CjkzAqWNmtOSa9ZgRr86p+DvJ0v N6bLD0hYXRv/TGBDdE9QTREhIDmTtGx8Oa5hHA2k= Date: Sat, 28 Sep 2019 00:56:56 -0700 From: Masami Hiramatsu To: Steven Rostedt Cc: LKML , Masami Hiramatsu , Srikar Dronamraju , Naveen Rao , Ravi Bangoria , Shuah Khan Subject: Re: [PATCH] selftests/ftrace: Fix same probe error test Message-Id: <20190928005656.cf7553118ebf292a3d44a59d@kernel.org> In-Reply-To: <20190927112514.00cc6e92@oasis.local.home> References: <20190927112514.00cc6e92@oasis.local.home> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Sep 2019 11:25:14 -0400 Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > The "same probe" selftest that tests that adding the same probe fails > doesn't add the same probe and passes, which fails the test. > > Fixes: b78b94b82122 ("selftests/ftrace: Update kprobe event error testcase") > Signed-off-by: Steven Rostedt (VMware) Oops, thanks! Acked-by: Masami Hiramatsu > --- > .../selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc > index 8a4025e912cb..ef1e9bafb098 100644 > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc > @@ -95,7 +95,7 @@ echo 'p:kprobes/testevent _do_fork abcd=\1' > kprobe_events > check_error 'p:kprobes/testevent _do_fork ^bcd=\1' # DIFF_ARG_TYPE > check_error 'p:kprobes/testevent _do_fork ^abcd=\1:u8' # DIFF_ARG_TYPE > check_error 'p:kprobes/testevent _do_fork ^abcd=\"foo"' # DIFF_ARG_TYPE > -check_error '^p:kprobes/testevent _do_fork' # SAME_PROBE > +check_error '^p:kprobes/testevent _do_fork abcd=\1' # SAME_PROBE > fi > > exit 0 > -- > 2.20.1 > -- Masami Hiramatsu