From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v1 0/2] perf stat: Support --all-kernel and --all-user
Date: Sun, 29 Sep 2019 17:29:13 +0200 [thread overview]
Message-ID: <20190929151022.GA16309@krava> (raw)
In-Reply-To: <20190925020218.8288-1-yao.jin@linux.intel.com>
On Wed, Sep 25, 2019 at 10:02:16AM +0800, Jin Yao wrote:
> This patch series supports the new options "--all-kernel" and "--all-user"
> in perf-stat.
>
> For example,
>
> root@kbl:~# perf stat -e cycles,instructions --all-kernel --all-user -a -- sleep 1
>
> Performance counter stats for 'system wide':
>
> 19,156,665 cycles:k
> 7,265,342 instructions:k # 0.38 insn per cycle
> 4,511,186,293 cycles:u
> 121,881,436 instructions:u # 0.03 insn per cycle
hi,
I think we should follow --all-kernel/--all-user behaviour from record
command, adding extra events seems like unnecesary complexity to me
jirka
>
> 1.001153540 seconds time elapsed
>
>
> root@kbl:~# perf stat -a --topdown --all-kernel -- sleep 1
>
> Performance counter stats for 'system wide':
>
> retiring:k bad speculation:k frontend bound:k backend bound:k
> S0-D0-C0 2 7.6% 1.8% 40.5% 50.0%
> S0-D0-C1 2 15.4% 3.4% 14.4% 66.8%
> S0-D0-C2 2 15.8% 5.1% 26.9% 52.2%
> S0-D0-C3 2 5.7% 5.7% 46.2% 42.4%
>
> 1.000771709 seconds time elapsed
>
> More detail information are in the patch descriptions.
>
> Jin Yao (2):
> perf stat: Support --all-kernel and --all-user options
> perf stat: Support topdown with --all-kernel/--all-user
>
> tools/perf/Documentation/perf-record.txt | 3 +-
> tools/perf/Documentation/perf-stat.txt | 7 +
> tools/perf/builtin-stat.c | 200 ++++++++++++++++++++++-
> tools/perf/util/stat-shadow.c | 167 ++++++++++++++-----
> tools/perf/util/stat.h | 23 +++
> 5 files changed, 353 insertions(+), 47 deletions(-)
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-09-29 15:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 2:02 [PATCH v1 0/2] perf stat: Support --all-kernel and --all-user Jin Yao
2019-09-25 2:02 ` [PATCH v1 1/2] perf stat: Support --all-kernel and --all-user options Jin Yao
2019-09-25 2:02 ` [PATCH v1 2/2] perf stat: Support topdown with --all-kernel/--all-user Jin Yao
2019-09-29 15:29 ` Jiri Olsa [this message]
2019-09-30 18:21 ` [PATCH v1 0/2] perf stat: Support --all-kernel and --all-user Andi Kleen
2019-09-30 19:28 ` Arnaldo Carvalho de Melo
2019-10-01 2:17 ` Andi Kleen
2019-10-10 6:46 ` Jin, Yao
2019-10-10 8:00 ` Jiri Olsa
2019-10-10 8:33 ` Jin, Yao
2019-10-10 12:33 ` Arnaldo Carvalho de Melo
2019-10-11 2:50 ` Jin, Yao
2019-10-11 7:21 ` Jiri Olsa
2019-10-12 1:49 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190929151022.GA16309@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).