From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E96C32792 for ; Mon, 30 Sep 2019 21:46:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2D18206BB for ; Mon, 30 Sep 2019 21:46:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732231AbfI3Vq0 convert rfc822-to-8bit (ORCPT ); Mon, 30 Sep 2019 17:46:26 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:39192 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726314AbfI3VqZ (ORCPT ); Mon, 30 Sep 2019 17:46:25 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C994C15435B54; Mon, 30 Sep 2019 11:06:54 -0700 (PDT) Date: Mon, 30 Sep 2019 11:06:51 -0700 (PDT) Message-Id: <20190930.110651.1802452095339417928.davem@davemloft.net> To: michal.vokac@ysoft.com Cc: andrew@lunn.ch, netdev@vger.kernel.org, vivien.didelot@gmail.com, linux-kernel@vger.kernel.org, f.fainelli@gmail.com, hkallweit1@gmail.com Subject: Re: [PATCH net] net: dsa: qca8k: Use up to 7 ports for all operations From: David Miller In-Reply-To: <1569488357-31415-1-git-send-email-michal.vokac@ysoft.com> References: <1569488357-31415-1-git-send-email-michal.vokac@ysoft.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-2 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 30 Sep 2019 11:06:55 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Vokáč Date: Thu, 26 Sep 2019 10:59:17 +0200 > The QCA8K family supports up to 7 ports. So use the existing > QCA8K_NUM_PORTS define to allocate the switch structure and limit all > operations with the switch ports. > > This was not an issue until commit 0394a63acfe2 ("net: dsa: enable and > disable all ports") disabled all unused ports. Since the unused ports 7-11 > are outside of the correct register range on this switch some registers > were rewritten with invalid content. > > Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family") > Fixes: a0c02161ecfc ("net: dsa: variable number of ports") > Fixes: 0394a63acfe2 ("net: dsa: enable and disable all ports") > Signed-off-by: Michal Vokáč Applied.