From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/3] perf jevents: Fix period for Intel fixed counters
Date: Mon, 30 Sep 2019 07:50:33 -0300 [thread overview]
Message-ID: <20190930105033.GE9622@kernel.org> (raw)
In-Reply-To: <20190927233546.11533-2-andi@firstfloor.org>
Em Fri, Sep 27, 2019 at 04:35:45PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
>
> The Intel fixed counters use a special table to override the JSON
> information. During this override the period information from
> the JSON file got dropped, which results in inst_retired.any
> and similar running with frequency mode instead of a period.
> Just specify the expected period in the table.
Thanks, applied.
- Arnaldo
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/pmu-events/jevents.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index d413761621b0..fa85e33762f7 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -449,12 +449,12 @@ static struct fixed {
> const char *name;
> const char *event;
> } fixed[] = {
> - { "inst_retired.any", "event=0xc0" },
> - { "inst_retired.any_p", "event=0xc0" },
> - { "cpu_clk_unhalted.ref", "event=0x0,umask=0x03" },
> - { "cpu_clk_unhalted.thread", "event=0x3c" },
> - { "cpu_clk_unhalted.core", "event=0x3c" },
> - { "cpu_clk_unhalted.thread_any", "event=0x3c,any=1" },
> + { "inst_retired.any", "event=0xc0,period=2000003" },
> + { "inst_retired.any_p", "event=0xc0,period=2000003" },
> + { "cpu_clk_unhalted.ref", "event=0x0,umask=0x03,period=2000003" },
> + { "cpu_clk_unhalted.thread", "event=0x3c,period=2000003" },
> + { "cpu_clk_unhalted.core", "event=0x3c,period=2000003" },
> + { "cpu_clk_unhalted.thread_any", "event=0x3c,any=1,period=2000003" },
> { NULL, NULL},
> };
>
> --
> 2.21.0
--
- Arnaldo
next prev parent reply other threads:[~2019-09-30 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 23:35 [PATCH 1/3] perf script brstackinsn: Fix recovery from LBR/binary mismatch Andi Kleen
2019-09-27 23:35 ` [PATCH 2/3] perf jevents: Fix period for Intel fixed counters Andi Kleen
2019-09-30 10:50 ` Arnaldo Carvalho de Melo [this message]
2019-10-07 14:49 ` [tip: perf/urgent] " tip-bot2 for Andi Kleen
2019-09-27 23:35 ` [PATCH 3/3] perf annotate: Improve handling of corrupted ~/.debug Andi Kleen
2019-09-30 10:50 ` [PATCH 1/3] perf script brstackinsn: Fix recovery from LBR/binary mismatch Arnaldo Carvalho de Melo
2019-10-07 14:49 ` [tip: perf/urgent] " tip-bot2 for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930105033.GE9622@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).