* [PATCH] of/fdt: don't ignore errors from of_setup_earlycon
@ 2019-09-10 5:58 Christoph Hellwig
2019-09-30 14:19 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2019-09-10 5:58 UTC (permalink / raw)
To: robh+dt, frowand.list; +Cc: devicetree, linux-kernel
If of_setup_earlycon we should keep on iterating earlycon options
instead of breaking out of the loop.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/of/fdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 9cdf14b9aaab..2f6bd03d8e27 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -946,8 +946,8 @@ int __init early_init_dt_scan_chosen_stdout(void)
if (fdt_node_check_compatible(fdt, offset, match->compatible))
continue;
- of_setup_earlycon(match, offset, options);
- return 0;
+ if (of_setup_earlycon(match, offset, options) == 0)
+ return 0;
}
return -ENODEV;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] of/fdt: don't ignore errors from of_setup_earlycon
2019-09-10 5:58 [PATCH] of/fdt: don't ignore errors from of_setup_earlycon Christoph Hellwig
@ 2019-09-30 14:19 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2019-09-30 14:19 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: robh+dt, frowand.list, devicetree, linux-kernel
On Tue, 10 Sep 2019 07:58:33 +0200, Christoph Hellwig wrote:
> If of_setup_earlycon we should keep on iterating earlycon options
> instead of breaking out of the loop.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/of/fdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-30 14:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10 5:58 [PATCH] of/fdt: don't ignore errors from of_setup_earlycon Christoph Hellwig
2019-09-30 14:19 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).