From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC5A0C352AA for ; Tue, 1 Oct 2019 10:36:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 911A921906 for ; Tue, 1 Oct 2019 10:36:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="GvWY6ZvG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730712AbfJAKf7 (ORCPT ); Tue, 1 Oct 2019 06:35:59 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:33720 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbfJAKf7 (ORCPT ); Tue, 1 Oct 2019 06:35:59 -0400 Received: by mail-ed1-f66.google.com with SMTP id c4so11458499edl.0 for ; Tue, 01 Oct 2019 03:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZNGuyH5VuGfp79kfCmqyKc3sZNZ698HUAysJogIW8J8=; b=GvWY6ZvGINP8k5fiHp2HCSyp++QYkRNHtKNKitVSQrpOL5yKvYytHwMSmIDySSNp9p BppOYXqm0K6ivvDJ+RIo1C22GSXi1/NMeRedaDWOnvnfYBVuatjVUdteMt7V4+B7CE8G HM2Av4gCcd6NwITVA0MBfQOqQ4wcuRNhns/lauZgGyCd6LUHpKQ+zSaVLZVw7DwyFX5A B0BL7HrR89eTEQFUrTb02YNbn6bZHmEh+4HjahRkUrb66lSX8Kpn4B9Wz6FTt05nzwdB 9jZ2+hXPD0rOEKByN+gpCx17AsxMS6SyjD7oUcm63jGlMnu8tpllxDDI/sJ4v7RWkxnO MJrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZNGuyH5VuGfp79kfCmqyKc3sZNZ698HUAysJogIW8J8=; b=D8qQwpiRYGBvfzBTEV5TyrHtLdV98r+RM7oisLccFyV5GAQPOkpJbP3foRnFj4Bweo HSZ/Ln0+//ZcazOQGvyd1D2fL16/akjpnUIyN4n38y+uSrIy4Q/Puy69mx5+KbLKB89s aDAJpQo3atanf65qImHLsnorCEeChpHvGGh/PO5dCt0ITKDM29ibUtTHlTmjcZ3tLxeP AEvj2k3WLZuZ3ZrpNwSoE6O1e44MzPBrFJ8odlXRfSjIRUiRFCdtRNmhi1lcIJc2i37W 3AR6KkVm3fVp9KyI9tVrfAOisdEonBkoG+ZvTjmOwuSnZPurdY1O8T0bDBo6qZXllWZz 9BDQ== X-Gm-Message-State: APjAAAVHI7sPg6g169ZC/DrKSWBv33aaXGi0Ix2gz+51r2+8L0qMAzrI ZA+2VETVifvA1QFnEOiE9qe2jQ== X-Google-Smtp-Source: APXvYqz87K8iJr9+PvdkjESjYxltd3GHd5aNw6kR4j971RAwDiqE2AOgqRqlUqNxEnnFUERsZY3ZGg== X-Received: by 2002:a17:906:c82d:: with SMTP id dd13mr12497351ejb.169.1569926157970; Tue, 01 Oct 2019 03:35:57 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id i30sm3057790ede.32.2019.10.01.03.35.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 03:35:57 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id ECBB2102FB8; Tue, 1 Oct 2019 13:35:57 +0300 (+03) Date: Tue, 1 Oct 2019 13:35:57 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/15] mm: Remove hpage_nr_pages Message-ID: <20191001103557.rqjc2zkvhym4ntre@box> References: <20190925005214.27240-1-willy@infradead.org> <20190925005214.27240-12-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190925005214.27240-12-willy@infradead.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 24, 2019 at 05:52:10PM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This function assumed that compound pages were necessarily PMD sized. > While that may be true for some users, it's not going to be true for > all users forever, so it's better to remove it and avoid the confusion > by just using compound_nr() or page_size(). > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov