From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF3A2C388F3 for ; Tue, 1 Oct 2019 11:13:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8648F21D79 for ; Tue, 1 Oct 2019 11:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569928387; bh=mMnBLzmYDQZr8tStqY6EhGbIdOFMamwVDjlacMbjHMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mPyvs79imjuaAhtoumW/ZZ2irSejk6ia7BazzUB3Ftrg4s+BkQW4SYbDyBsBXU4i6 saQg3GzyENr2CtgWvH+rCtKfRLLdhIEKQ0hn2/ta8kheViYLz5EdzGZ5eno3DkmheV 8k7aYWNjFk6pY8JsNoefL6IbgIM92uRkPemxz/zI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731648AbfJALNG (ORCPT ); Tue, 1 Oct 2019 07:13:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:35052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731480AbfJALNF (ORCPT ); Tue, 1 Oct 2019 07:13:05 -0400 Received: from quaco.ghostprotocols.net (177.206.223.101.dynamic.adsl.gvt.net.br [177.206.223.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9659021920; Tue, 1 Oct 2019 11:13:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569928385; bh=mMnBLzmYDQZr8tStqY6EhGbIdOFMamwVDjlacMbjHMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qiSEdPtgLMpWZViDmhe/fMeL8997U5hBDKQaz6dluW6xpZNtZLFFoVmHaHxhzrz/0 s3KG0P03aNfH+FW5GTHJgV/D58OvjJAz3RNJ0aC+cCaa5qS9U5znVfjrmm8RIDm3L/ ZFlqpTE5Dk756CxsD26hvZy1XVoliCYJzwB+rYF0= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Ian Rogers , stable@vger.kernel.org, Alexander Shishkin , Andi Kleen , Jiri Olsa , Peter Zijlstra , Stephane Eranian , Wang Nan , Arnaldo Carvalho de Melo Subject: [PATCH 09/24] perf llvm: Don't access out-of-scope array Date: Tue, 1 Oct 2019 08:12:01 -0300 Message-Id: <20191001111216.7208-10-acme@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191001111216.7208-1-acme@kernel.org> References: <20191001111216.7208-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ian Rogers The 'test_dir' variable is assigned to the 'release' array which is out-of-scope 3 lines later. Extend the scope of the 'release' array so that an out-of-scope array isn't accessed. Bug detected by clang's address sanitizer. Fixes: 07bc5c699a3d ("perf tools: Make fetch_kernel_version() publicly available") Cc: stable@vger.kernel.org # v4.4+ Signed-off-by: Ian Rogers Cc: Alexander Shishkin Cc: Andi Kleen Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Wang Nan Link: http://lore.kernel.org/lkml/20190926220018.25402-1-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/llvm-utils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/llvm-utils.c b/tools/perf/util/llvm-utils.c index 8d04e3d070b1..8b14e4a7f1dc 100644 --- a/tools/perf/util/llvm-utils.c +++ b/tools/perf/util/llvm-utils.c @@ -233,14 +233,14 @@ static int detect_kbuild_dir(char **kbuild_dir) const char *prefix_dir = ""; const char *suffix_dir = ""; + /* _UTSNAME_LENGTH is 65 */ + char release[128]; + char *autoconf_path; int err; if (!test_dir) { - /* _UTSNAME_LENGTH is 65 */ - char release[128]; - err = fetch_kernel_version(NULL, release, sizeof(release)); if (err) -- 2.21.0