From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B079ECE587 for ; Tue, 1 Oct 2019 13:54:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 119DB20815 for ; Tue, 1 Oct 2019 13:54:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="XE4xuttd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388861AbfJANyc (ORCPT ); Tue, 1 Oct 2019 09:54:32 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:46766 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388754AbfJANyc (ORCPT ); Tue, 1 Oct 2019 09:54:32 -0400 Received: by mail-qt1-f194.google.com with SMTP id u22so21636743qtq.13 for ; Tue, 01 Oct 2019 06:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BlIRQGk1pr2xNfAlAuq52KNMvxNuXtY13udgYZxJPDQ=; b=XE4xuttdIhnl4u6Y/iBs62HmAUIyp5ru9LZU1lct2oxegtgkMkl71CeYp9Ma5bEC2g DMBhfJn99zfMBlmu31T9t1c6CFyP4qfaVYJUlZgeV9bhdcqH9Gz3kVBEZJgsHyAJD24I WKsLDhrE4ZRFwx+pDoBDPSdkUztqcxv+h3341Gp5A1eB2dBGBAG9HwcRNGRGodIlIwR+ GHengGUZ5yaQU0PZoDZZzqUT6BXyKgLP4ghrI30HwLRGgG6Bm6cOqdHwBZ4TyJfJo/X8 1MXdNeNrnn3nH4w3QbUgdlzppJMJJzUZn15H/DRLa186a7ow9mjrmYBtn9E2lmQMpYu5 ZOsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BlIRQGk1pr2xNfAlAuq52KNMvxNuXtY13udgYZxJPDQ=; b=SQtqTgKfM/BoNhUwC+CMbfeWDdu7AAAoUN3MAsCRt3V+g/PsXbHRNXXlR5ruu4rs0i GZQ6fg+qL04fl+Nc6gpvrUOdZIStRRd4qtJP3GOCdMk1OG85XoFhDdyrY5Ac7CRk4P8n a8ZiaZyRyiU/j0UtENT/s2g9LDSuGyMU3R1QkB87MaYMP5oT73xWdnTCP4zA8/kyysVm Pe/oBl+tTBZI7QyPkNaaaWYL2HbWgosNwyU9qbnhT+kKa9wlia7VHNAcKqYgDT5kjA7M byLi+ct99vX1gXCPfoo/K68NlxV5JEW7Ao4KHPl2KCb3zFIOfDug9wJo8KYrhvMCZ0va eEzQ== X-Gm-Message-State: APjAAAUEGsMuCzgOUSaAwD+bRnoOgVaS1Z4xTuMGYLO+cIx7KatTGkz9 W4OhpS9kR1TmoLN8AMYncTee7A== X-Google-Smtp-Source: APXvYqzcSPa2CE4T3TD0U+DLWNizMhHBjoacjTw0iHRjOVAb0codaIbWWfjADA/A776+fzV4c/ZGMg== X-Received: by 2002:aed:2726:: with SMTP id n35mr29910659qtd.171.1569938071033; Tue, 01 Oct 2019 06:54:31 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id c41sm13595334qte.8.2019.10.01.06.54.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Oct 2019 06:54:30 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iFIbm-00073R-5P; Tue, 01 Oct 2019 10:54:30 -0300 Date: Tue, 1 Oct 2019 10:54:30 -0300 From: Jason Gunthorpe To: Navid Emamdoost Cc: leon@kernel.org, emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, Potnuri Bharat Teja , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] RDMA: release allocated skb Message-ID: <20191001135430.GA27086@ziepe.ca> References: <20190923050823.GL14368@unreal> <20190923155300.20407-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190923155300.20407-1-navid.emamdoost@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2019 at 10:52:59AM -0500, Navid Emamdoost wrote: > In create_cq, the allocated skb buffer needs to be released on error > path. > Moved the kfree_skb(skb) under err4 label. This didn't move anything > Signed-off-by: Navid Emamdoost > drivers/infiniband/hw/cxgb4/cq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c > index b1bb61c65f4f..1886c1af10bc 100644 > +++ b/drivers/infiniband/hw/cxgb4/cq.c > @@ -173,6 +173,7 @@ static int create_cq(struct c4iw_rdev *rdev, struct t4_cq *cq, > err4: > dma_free_coherent(&rdev->lldi.pdev->dev, cq->memsize, cq->queue, > dma_unmap_addr(cq, mapping)); > + kfree_skb(skb); > err3: > kfree(cq->sw_queue); > err2: This looks wrong to me: int c4iw_ofld_send(struct c4iw_rdev *rdev, struct sk_buff *skb) { int error = 0; if (c4iw_fatal_error(rdev)) { kfree_skb(skb); pr_err("%s - device in error state - dropping\n", __func__); return -EIO; } error = cxgb4_ofld_send(rdev->lldi.ports[0], skb); if (error < 0) kfree_skb(skb); return error < 0 ? error : 0; } Jason