From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56DA5ECE587 for ; Tue, 1 Oct 2019 19:34:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30F3021A4C for ; Tue, 1 Oct 2019 19:34:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569958471; bh=X0ODSdcm/NVAagYO7ccY+UsMr3yH1nYd7QAe62Cvk1s=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=t0tLHlj06uPC/Sr0FZZ9KRHaro/P8rmz3i5bQEVI9OWzdPp7j/V0ucTiZfXZsqgTD o6W3td1T4OB3OngBdQsO79trcswrBGqtnbpjrO0HdJCg8cm8Q4gC9KdUAY6L2xS+QW uuP1K/J+bqf9mG6wGFiqR2Y2RPK9m9d598hBdbAs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727016AbfJATea (ORCPT ); Tue, 1 Oct 2019 15:34:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:53834 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbfJATea (ORCPT ); Tue, 1 Oct 2019 15:34:30 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2EB7020B7C; Tue, 1 Oct 2019 19:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569958469; bh=X0ODSdcm/NVAagYO7ccY+UsMr3yH1nYd7QAe62Cvk1s=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=g55px0NQzX8MpOTtfvfb2etHfMWOg3sxn8w/FHf64rDOsoeZP9nBWtFbiC8JWfXmA B6U37pYseJdyozoirhZjl0l6K9O2pJSUV+k2BLC+nFKaRvlbZnNTgawggYkrFslod+ oDZFmAwT0dHjVmduL4xiAnV/WWz1VDYFx31vJTCY= Date: Tue, 1 Oct 2019 14:34:27 -0500 From: Bjorn Helgaas To: Karol Herbst Cc: Mika Westerberg , LKML , Lyude Paul , Linux PCI , dri-devel , nouveau , "Rafael J. Wysocki" , Linux PM Subject: Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges Message-ID: <20191001193427.GA59137@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 01, 2019 at 06:21:28PM +0200, Karol Herbst wrote: > On Tue, Oct 1, 2019 at 3:27 PM Bjorn Helgaas wrote: > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > > On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg > > > wrote: > > > > > > > > On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: > > > > > still happens with your patch applied. The machine simply gets shut down. > > > > > > > > > > dmesg can be found here: > > > > > https://gist.githubusercontent.com/karolherbst/40eb091c7b7b33ef993525de660f1a3b/raw/2380e31f566e93e5ba7c87ef545420965d4c492c/gistfile1.txt > > > > > > > > Looking your dmesg: > > > > > > > > Sep 30 17:24:27 kernel: nouveau 0000:01:00.0: DRM: DCB version 4.1 > > > > Sep 30 17:24:27 kernel: nouveau 0000:01:00.0: DRM: MM: using COPY for buffer copies > > > > Sep 30 17:24:27 kernel: [drm] Initialized nouveau 1.3.1 20120801 for 0000:01:00.0 on minor 1 > > > > > > > > I would assume it runtime suspends here. Then it wakes up because of PCI > > > > access from userspace: > > > > > > > > Sep 30 17:24:42 kernel: pci_raw_set_power_state: 56 callbacks suppressed > > > > > > > > and for some reason it does not get resumed properly. There are also few > > > > warnings from ACPI that might be relevant: > > > > > > > > Sep 30 17:24:27 kernel: ACPI Warning: \_SB.PCI0.GFX0._DSM: Argument #4 type mismatch - Found [Buffer], ACPI requires [Package] (20190509/nsarguments-59) > > > > Sep 30 17:24:27 kernel: ACPI Warning: \_SB.PCI0.PEG0.PEGP._DSM: Argument #4 type mismatch - Found [Buffer], ACPI requires [Package] (20190509/nsarguments-59) > > > > > > afaik this is the case for essentially every laptop out there. > > > > I think we should look into this a little bit. > > acpi_ns_check_argument_types() checks the argument type and prints > > this message, but AFAICT it doesn't actually fix anything or prevent > > execution of the method, so I have no idea what happens when we > > actually execute the _DSM. > > I can assure you that this warning happens on every single laptop out > there with dual Nvidia graphics and it's essentially just a firmware > bug. And it never caused any issues on any of the older laptops (or > newest one for that matter). Rafael, do you know anything about this? If ACPI has some sort of workaround so it can execute the method correctly anyway, maybe we should remove or reword the warning? Or if this does prevent execution of the method, maybe we need to add a workaround since the problem is so prevalent in the field? > > If we execute this _DSM as part of power management, and the _DSM > > doesn't work right, it would be no surprise that we have problems. > > > > Maybe we could learn something by turning on ACPI_DB_PARSE output (see > > Documentation/firmware-guide/acpi/debug.rst). > > > > You must have an acpidump already from all your investigation. Can > > you put it somewhere, e.g., bugzilla.kernel.org, and include a URL? > > Will do so later, right now I am traveling to XDC and will have more > time for that then.