From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=YRFP=X2=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 601E3C352AA
	for <linux-kernel@archiver.kernel.org>; Tue,  1 Oct 2019 21:49:16 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 35B0C21924
	for <linux-kernel@archiver.kernel.org>; Tue,  1 Oct 2019 21:49:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1569966556;
	bh=3O9ytnipO3eaLjocEP/4hY0yll0ieUCxfn0NQMgCwso=;
	h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From;
	b=JbYDIKvr0OjVdNWWgKveCe5HM+55h9ds0/nFheGqPghe3iIT4sSJVdxrEv0E61Rz/
	 wq4BQiy5xr4dDVMXlTX//3lMfTmK4lGB6b/qIPSHSYeh/TPN0bXApOwG7nGvDqouO7
	 xBTW0dW841cJp9kENiGEQ03AKedgb7vlEvyFXJZg=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727980AbfJAVtP (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 1 Oct 2019 17:49:15 -0400
Received: from mail.kernel.org ([198.145.29.99]:33444 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726681AbfJAVtP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Oct 2019 17:49:15 -0400
Received: from localhost (unknown [69.71.4.100])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id B78382133F;
        Tue,  1 Oct 2019 21:49:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1569966554;
        bh=3O9ytnipO3eaLjocEP/4hY0yll0ieUCxfn0NQMgCwso=;
        h=Date:From:To:Cc:Subject:In-Reply-To:From;
        b=ZzEhv2Sb/gm84Co1ZG1Z8fWWpyF8VVT8b2wL4MClmWB1nY/RZ8MXJTfUiu/qY6JYM
         VS2fNnFciEoUobi/wnl151THzhqrqWUaGHY3uc9UwQLtDcpAyilH/jbHCRK6uMLH4U
         ViUoga04FvmfmF96/78thqs0YjY6xfihkZ1+pC8Q=
Date:   Tue, 1 Oct 2019 16:49:12 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Andrew Murray <andrew.murray@arm.com>
Cc:     Tom Joseph <tjoseph@cadence.com>, linux-pci@vger.kernel.org,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.
Message-ID: <20191001214912.GA78523@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191001100727.GJ42880@e119886-lin.cambridge.arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 01, 2019 at 11:07:28AM +0100, Andrew Murray wrote:
> Hi Tom,
> 
> Thanks for the patch.
> 
> I'd suggest that you rename the subject of this series to "PCI: cadence: ..."
> to be consistent with the existing commit history, e.g. git log 
> --oneline drivers/pci/controller/pcie-cadence* - you'll also see that you
> don't need a full stop at the end, and you ought to also change the tense
> of the subject, e.g. Refactor driver to ...
> 
> See comments inline...

Andrew, thank you very much for your detailed and thoughtful reviews
here and elsewhere.  It is a huge help.

Bjorn