From: Maxime Ripard <mripard@kernel.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Chen-Yu Tsai <wens@csie.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 0/3] drm/sun4i: dsi: misc timing fixes
Date: Wed, 2 Oct 2019 12:36:42 +0200 [thread overview]
Message-ID: <20191002103642.jlbs44v4kwnxhrge@gilmour> (raw)
In-Reply-To: <20191001080253.6135-1-icenowy@aosc.io>
[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]
Hi,
On Tue, Oct 01, 2019 at 04:02:50PM +0800, Icenowy Zheng wrote:
> This patchset fixes some portion of timing calculation in sun6i_mipi_dsi
> driver according to the BSP driver.
>
> Two of the patches are reverting, one is fixing some misread of the BSP
> source code, another is fixing a wrong refactor that actually breaks the
> formula.
>
> The other non-reverting patch is fixing a porch error which is usually
> seen in the original driver commit. Most of porch errors are then fixed,
> but this one gets ignored.
>
> By applying these patches, several DSI panels are tested to be driven
> properly by the timing provided by the vendor, including the LCD panel
> of PinePhone "Don't Be Evil" DevKit, the final PinePhone panel and the
> panel on PineTab. Without these patches they need dirty timing hacks to
> work.
Thanks for going after that issue. Can you provide references to the
BSP on the various patches?
Ideally, having the panel drivers, and the panel datasheet would help.
Thanks!
Maxime
PS: where can we get one of those devices?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-10-02 10:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 8:02 [PATCH 0/3] drm/sun4i: dsi: misc timing fixes Icenowy Zheng
2019-10-01 8:02 ` [PATCH 1/3] Revert "drm/sun4i: dsi: Change the start delay calculation" Icenowy Zheng
2019-10-03 7:08 ` [linux-sunxi] " Jagan Teki
2019-10-03 13:19 ` Maxime Ripard
2019-10-03 13:21 ` Icenowy Zheng
2019-10-03 13:34 ` Maxime Ripard
2019-10-01 8:02 ` [PATCH 2/3] drm/sun4i: dsi: fix DRQ calculation Icenowy Zheng
2019-10-03 4:37 ` [linux-sunxi] " Jagan Teki
2019-10-01 8:02 ` [PATCH 3/3] Revert "drm/sun4i: dsi: Rework a bit the hblk calculation" Icenowy Zheng
2019-10-03 4:23 ` [linux-sunxi] " Jagan Teki
2019-10-06 14:44 ` Icenowy Zheng
2019-10-06 15:12 ` Icenowy Zheng
2019-10-07 15:19 ` Ondřej Jirman
2019-10-02 10:36 ` Maxime Ripard [this message]
2019-10-03 3:58 ` [PATCH 0/3] drm/sun4i: dsi: misc timing fixes Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002103642.jlbs44v4kwnxhrge@gilmour \
--to=mripard@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).