linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Kiper <daniel.kiper@oracle.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, bp@alien8.de, corbet@lwn.net,
	dpsmith@apertussolutions.com, eric.snowberg@oracle.com,
	kanth.ghatraju@oracle.com, konrad.wilk@oracle.com,
	mingo@redhat.com, ross.philipson@oracle.com, tglx@linutronix.de
Subject: Re: [PATCH v2 1/3] x86/boot: Introduce the kernel_info
Date: Wed, 2 Oct 2019 14:00:18 +0200	[thread overview]
Message-ID: <20191002120018.d7wbpf3zusl4dcsc@tomti.i.net-space.pl> (raw)
In-Reply-To: <dda802de-2efe-3d22-7816-6da36bf9ebf8@zytor.com>

On Tue, Oct 01, 2019 at 03:28:01PM -0700, H. Peter Anvin wrote:
> On 2019-10-01 04:41, Daniel Kiper wrote:
> >
> > OK, so, this is more or less what I had in my v3 patch before sending
> > this email. So, it looks that I am on good track. Great! Though I am not
> > sure that we should have magic for chunked objects. If yes could you
> > explain why? I would just leave len for chunked objects.
> >
>
> It makes it easier to validate the contents (bugs happen...), and would allow
> for multiple chunks that could come from different object files if it ever
> becomes necessary for some reason.

OK.

> We could also just say that dynamic chunks don't even have pointers, and let
> the boot loader just walk the list.

Yeah... That seams simpler. I will do that.

> >> Also "InfO" is a pretty hideous magic. In general, all-ASCII magics have much
> >> higher risk of collision than *RANDOM* binary numbers. However, for a chunked
> >> architecture they do have the advantage that they can be used also as a human
> >> name or file name for the chunk, e.,g. in sysfs, so maybe something like
> >> "LnuX" or even "LToP" for the top-level chunk might make sense.
> >>
> >> How does that sound?
> >
> > Well, your proposals are more cryptic, especially the second one, than
> > mine but I tend to agree that more *RANDOM* magics are better. So,
> > I would choose "LToP" if you decipher it for me. Linux Top?
> >
>
> Yes, Linux top [structure].

Thx!

Daniel

  reply	other threads:[~2019-10-02 12:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 16:36 [PATCH v2 0/3] x86/boot: Introduce the kernel_info et consortes Daniel Kiper
2019-07-04 16:36 ` [PATCH v2 1/3] x86/boot: Introduce the kernel_info Daniel Kiper
2019-07-12 16:04   ` hpa
2019-09-30 15:01     ` Daniel Kiper
2019-09-30 17:18       ` H. Peter Anvin
2019-10-01 11:41         ` Daniel Kiper
2019-10-01 22:28           ` H. Peter Anvin
2019-10-02 12:00             ` Daniel Kiper [this message]
2019-07-04 16:36 ` [PATCH v2 2/3] x86/boot: Introduce the setup_indirect Daniel Kiper
2019-07-12 15:56   ` hpa
2019-10-01 14:47     ` Daniel Kiper
2019-07-04 16:36 ` [PATCH v2 3/3] x86/boot: Introduce the kernel_info.setup_type_max Daniel Kiper
2019-07-12 15:59   ` hpa
2019-07-12 11:58 ` [PATCH v2 0/3] x86/boot: Introduce the kernel_info et consortes Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191002120018.d7wbpf3zusl4dcsc@tomti.i.net-space.pl \
    --to=daniel.kiper@oracle.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dpsmith@apertussolutions.com \
    --cc=eric.snowberg@oracle.com \
    --cc=hpa@zytor.com \
    --cc=kanth.ghatraju@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=ross.philipson@oracle.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).