linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Rob Herring <robh@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Joe Perches <joe@perches.com>,
	devicetree@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v7 09/13] lib/vsprintf: Add a note on re-using %pf or %pF
Date: Wed, 2 Oct 2019 15:02:20 +0300	[thread overview]
Message-ID: <20191002120220.GF972@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20190924104549.qiayzhr7zikja7sp@pathway.suse.cz>

On Tue, Sep 24, 2019 at 12:45:49PM +0200, Petr Mladek wrote:
> On Wed 2019-09-18 16:34:15, Sakari Ailus wrote:
> > Add a note warning of re-use of obsolete %pf or %pF extensions.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > ---
> >  lib/vsprintf.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> > index b00b57f9f911f..df59818537b52 100644
> > --- a/lib/vsprintf.c
> > +++ b/lib/vsprintf.c
> > @@ -2008,6 +2008,8 @@ static char *kobject_string(char *buf, char *end, void *ptr,
> >   * - 'S' For symbolic direct pointers (or function descriptors) with offset
> >   * - 's' For symbolic direct pointers (or function descriptors) without offset
> >   * - '[Ss]R' as above with __builtin_extract_return_addr() translation
> > + * - '[Ff]' Obsolete an now unsupported extension for printing direct pointers
> > + *	    or function descriptors. Be careful when re-using %pf or %pF!
> 
> I am not a native speaker but the sentence is hard to parse to me.
> Also I miss the word 'symbolic'. IMHO, it described that the output
> was a symbol name.
> 
> What about something like?
> 
>   * - '[Ff]' %pf and %pF were obsoleted and later removed in favor of
>   *	    %ps and %pS. Be careful when re-using these specifiers.

Yes, I'll use this in v8.

-- 
Sakari Ailus
sakari.ailus@linux.intel.com

  reply	other threads:[~2019-10-02 12:02 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18 13:34 [PATCH v7 00/13] Device property improvements, add %pfw format specifier Sakari Ailus
2019-09-18 13:34 ` [PATCH v7 01/13] tools lib traceevent: Convert remaining %p[fF] users to %p[sS] Sakari Ailus
2019-09-18 13:58   ` Steven Rostedt
2019-09-18 15:22   ` Andy Shevchenko
2019-09-20 16:20   ` [tip: perf/urgent] " tip-bot2 for Sakari Ailus
2019-09-18 13:34 ` [PATCH v7 02/13] software node: Get reference to parent swnode in get_parent op Sakari Ailus
2019-09-18 13:34 ` [PATCH v7 03/13] software node: Make argument to to_software_node const Sakari Ailus
2019-09-18 13:34 ` [PATCH v7 04/13] device property: Move fwnode_get_parent() up Sakari Ailus
2019-09-18 13:34 ` [PATCH v7 05/13] device property: Add functions for accessing node's parents Sakari Ailus
2019-09-18 13:34 ` [PATCH v7 06/13] device property: Add fwnode_get_name for returning the name of a node Sakari Ailus
2019-09-18 13:34 ` [PATCH v7 07/13] device property: Add a function to obtain a node's prefix Sakari Ailus
2019-09-18 13:34 ` [PATCH v7 08/13] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Sakari Ailus
2019-09-19  7:58   ` Rafael J. Wysocki
2019-09-24 10:38   ` Petr Mladek
2019-10-02 12:06     ` Sakari Ailus
2019-09-18 13:34 ` [PATCH v7 09/13] lib/vsprintf: Add a note on re-using %pf or %pF Sakari Ailus
2019-09-18 14:00   ` Steven Rostedt
2019-09-18 14:29     ` Sakari Ailus
2019-09-18 14:33   ` [PATCH v8 " Sakari Ailus
2019-09-24 10:45   ` [PATCH v7 " Petr Mladek
2019-10-02 12:02     ` Sakari Ailus [this message]
2019-09-18 13:34 ` [PATCH v7 10/13] lib/vsprintf: Make use of fwnode API to obtain node names and separators Sakari Ailus
2019-09-18 13:34 ` [PATCH v7 11/13] lib/vsprintf: OF nodes are first and foremost, struct device_nodes Sakari Ailus
2019-09-18 13:34 ` [PATCH v7 12/13] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Sakari Ailus
2019-09-24 12:47   ` Petr Mladek
2019-09-18 13:34 ` [PATCH v7 13/13] lib/test_printf: Add tests for %pfw printk modifier Sakari Ailus
2019-09-24 12:54   ` Petr Mladek
2019-09-19  8:00 ` [PATCH v7 00/13] Device property improvements, add %pfw format specifier Rafael J. Wysocki
2019-09-19  8:29   ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191002120220.GF972@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=joe@perches.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).