From: Greg KH <gregkh@linuxfoundation.org>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: "Andreas Färber" <afaerber@suse.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Enrico Weigelt" <lkml@metux.net>,
"Oliver Hartkopp" <socketcan@hartkopp.net>,
"J. Kiszka" <jan.kiszka@siemens.com>,
"Frank Iwanitz" <friw@hms-networks.de>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v1 3/5] staging: fieldbus core: add support for device configuration
Date: Wed, 2 Oct 2019 17:23:58 +0200 [thread overview]
Message-ID: <20191002152358.GA1748000@kroah.com> (raw)
In-Reply-To: <CAGngYiXWF-qwTiC95oUQobYRwuruZ6Uu7USwPRqhhyw-mogv7w@mail.gmail.com>
On Wed, Oct 02, 2019 at 11:07:47AM -0400, Sven Van Asbroeck wrote:
> On Mon, Sep 30, 2019 at 10:09 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > Why is a new way of doing configuration needed here? What does this
> > provide that the current code doesn't already do?
>
> The fieldbus core doesn't have a configuration mechanism yet. This
> patch adds one.
> I deliberately omitted configuration when the core was added - I wanted to keep
> complexity to a minimum. I'm sorry I didn't make this clearer.
>
> As a result, the current core can only work with cards that either don't require
> any config, or get it straight from the network/PLC. Profinet is a good example
> of this. Most cards do require config however. So does the hms flnet card, which
> I tried to add in the patchset.
If the code works with some subset now, then why not work to get this
cleaned up properly and out of staging and then add new features like
this type of configuration system afterward?
Why is this a requirement to add while the code is in staging?
thanks,
greg k-h
next prev parent reply other threads:[~2019-10-02 15:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 18:35 [PATCH v1 0/5] Introduce fieldbus_dev configuration interface Sven Van Asbroeck
2019-09-18 18:35 ` [PATCH v1 1/5] staging: fieldbus core: remove unused strings Sven Van Asbroeck
2019-09-18 18:35 ` [PATCH v1 2/5] staging: fieldbus: move "offline mode" definition to fieldbus core Sven Van Asbroeck
2019-09-18 18:35 ` [PATCH v1 3/5] staging: fieldbus core: add support for device configuration Sven Van Asbroeck
2019-09-30 14:06 ` Greg KH
2019-10-02 15:07 ` Sven Van Asbroeck
2019-10-02 15:23 ` Greg KH [this message]
2019-10-02 15:43 ` Sven Van Asbroeck
2019-09-18 18:35 ` [PATCH v1 4/5] staging: fieldbus core: add support for FL-NET devices Sven Van Asbroeck
2019-09-30 14:07 ` Greg KH
2019-10-02 15:08 ` Sven Van Asbroeck
2019-09-18 18:35 ` [PATCH v1 5/5] staging: fieldbus: add support for HMS FL-NET industrial controller Sven Van Asbroeck
2019-09-30 14:05 ` Greg KH
2019-10-02 15:08 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002152358.GA1748000@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=afaerber@suse.de \
--cc=friw@hms-networks.de \
--cc=jan.kiszka@siemens.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metux.net \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).