From: <Narendra.K@dell.com>
To: <Narendra.K@dell.com>
Cc: <geert@linux-m68k.org>, <Mario.Limonciello@dell.com>,
<ard.biesheuvel@linaro.org>, <linux-efi@vger.kernel.org>,
<mingo@kernel.org>, <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>, <james.morse@arm.com>,
<tanxiaofei@huawei.com>
Subject: Re: [PATCH 4/5] efi: Export Runtime Configuration Interface table to sysfs
Date: Wed, 2 Oct 2019 19:49:15 +0000 [thread overview]
Message-ID: <20191002194905.GA3983@localhost.localdomain> (raw)
In-Reply-To: <20191002102159.GA2109@localhost.localdomain>
On Wed, Oct 02, 2019 at 10:22:10AM +0000, K, Narendra wrote:
[...]
> > I hope I managed to convince you of the benefits.
>
> Thank you Geert. The description is helpful. I am working on it.
> As I understand, the issue is 'make oldconfig' provides a prompt to the user
> and user is expecting that a prompt is not needed as the option is not
> relevant.
>
> I cloned upstream kernel 5.3.2 as it does not have EFI_RCI2_TABLE option
> and generated a .config by calling 'make defconfig'. The .config has
> COMPILE_TEST set to n. I copied it to 5.4-rc1 and added 'depends on COMPILE_TEST'
> to drivers/firmware/efi/Kconfig (did not add CONFIG_X86 because it is
> set to y by the defconfig from 5.3.2). 'make oldconfig' still provides a
> prompt for CONFIG_EFI_RCI2_TABLE.
>
> I removed 'depends on COMPILE_TEST' from Kconfig and modified it to
> include the below change -
>
>
> config EFI_RCI2_TABLE
> bool
> prompt "EFI Runtime Configuration Interface Table Version 2 Support" if COMPILE_TEST
> default n
> help
>
> Adding the condition to the 'prompt' section seems to have desired
> result. With this change, 'make oldconfig' did not provide a prompt.
>
> It seems like 'make oldconfig' will provide a prompt to the user if the
> CONFIG option is new and providing the prompt does not depend on the
> 'depends on' section. It seems to be dependent on the 'prompt' section.
>
> Any thoughts ? If the above understanding is correct, I will work to
> submit a patch with 'prompt' section modified to contain
>
> prompt "EFI Runtime Configuration Interface Table Version 2 Support" if X86 || COMPILE_TEST
Geert/Ard,
I submitted the patch with above approach.
--
With regards,
Narendra K
next prev parent reply other threads:[~2019-10-02 19:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 15:04 [GIT PULL 0/5] EFI updates for v5.4 Ard Biesheuvel
2019-08-12 15:04 ` [PATCH 1/5] efi: x86: move efi_is_table_address() into arch/x86 Ard Biesheuvel
2019-08-12 15:04 ` [PATCH 2/5] efi/x86: move UV_SYSTAB handling " Ard Biesheuvel
2019-08-12 15:04 ` [PATCH 3/5] efi: ia64: move SAL systab handling out of generic EFI code Ard Biesheuvel
2019-08-12 15:04 ` [PATCH 4/5] efi: Export Runtime Configuration Interface table to sysfs Ard Biesheuvel
2019-10-01 8:51 ` Geert Uytterhoeven
2019-10-01 8:54 ` Ard Biesheuvel
2019-10-01 9:03 ` Geert Uytterhoeven
2019-10-01 9:41 ` Ard Biesheuvel
2019-10-01 13:20 ` Mario.Limonciello
2019-10-01 18:01 ` Narendra.K
2019-10-01 18:23 ` Geert Uytterhoeven
2019-10-02 10:22 ` Narendra.K
2019-10-02 19:49 ` Narendra.K [this message]
2019-08-12 15:04 ` [PATCH 5/5] efi: cper: print AER info of PCIe fatal error Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002194905.GA3983@localhost.localdomain \
--to=narendra.k@dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=ard.biesheuvel@linaro.org \
--cc=geert@linux-m68k.org \
--cc=james.morse@arm.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tanxiaofei@huawei.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).