From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf script: Allow --time with --reltime
Date: Thu, 3 Oct 2019 12:18:27 +0200 [thread overview]
Message-ID: <20191003101827.GA23291@krava> (raw)
In-Reply-To: <20191002164642.1719-1-andi@firstfloor.org>
On Wed, Oct 02, 2019 at 09:46:42AM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> The original --reltime patch forbid --time with --reltime.
>
> But it turns out --time doesn't really care about --reltime, because
> the relative time is only used at final output, while
> the time filtering always works earlier on absolute time.
>
> So just remove the check and allow combining the two options.
>
> Fixes: 90b10f47c0ee ("perf script: Support relative time")
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
> ---
> tools/perf/builtin-script.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 32b17d51c982..7481003b2761 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -3601,11 +3601,6 @@ int cmd_script(int argc, const char **argv)
> }
> }
>
> - if (script.time_str && reltime) {
> - fprintf(stderr, "Don't combine --reltime with --time\n");
> - return -1;
> - }
> -
> if (itrace_synth_opts.callchain &&
> itrace_synth_opts.callchain_sz > scripting_max_stack)
> scripting_max_stack = itrace_synth_opts.callchain_sz;
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-10-03 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 16:46 [PATCH] perf script: Allow --time with --reltime Andi Kleen
2019-10-03 10:18 ` Jiri Olsa [this message]
2019-10-03 14:12 ` Arnaldo Carvalho de Melo
2019-10-15 5:31 ` [tip: perf/core] " tip-bot2 for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003101827.GA23291@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).