From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEC77C10F14 for ; Thu, 3 Oct 2019 13:34:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8180620700 for ; Thu, 3 Oct 2019 13:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570109691; bh=ApHvRgiWA6cRhXYdkclbMkQdh5sxi8kdnz0cqB74Gvg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OC8uNlaWOpmiVtCq29aoFCHQTqNt0O8LSCk4ahwhRdAfCLZB50efXcGpb+pOgwYBM TlxbatKpd89cuNjpWLJ27qr8mEQaTx3hN9XEExaNyZRajOtVBSmZtzcdntvmVmDYRe 5cK6Aar3D5hFkfbVFKA4HTM3xo+L7LM8GE3dUaTA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730481AbfJCNeu (ORCPT ); Thu, 3 Oct 2019 09:34:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:51154 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729589AbfJCNeu (ORCPT ); Thu, 3 Oct 2019 09:34:50 -0400 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A28D20700; Thu, 3 Oct 2019 13:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570109689; bh=ApHvRgiWA6cRhXYdkclbMkQdh5sxi8kdnz0cqB74Gvg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MZgD+R+QDCfhRydR0uPmxahHwv3pyjs/0u7P5qUaN9ZrKn1EY1NeQb/rH6Qp1HMaA YcYFxynnwZD1MteDBBoz7ouXRHx5raneJ0RAlMFML8nRlR3GaDp4GD6qyiXqRsBbR5 GQWIUsIluS0VZfxPzYONnrO86rxq51tNC+Pk2opg= Date: Thu, 3 Oct 2019 15:34:47 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: linux-arm-kernel@lists.infradead.org, Jagan Teki , David Airlie , linux-sunxi , linux-kernel , dri-devel , Chen-Yu Tsai , Daniel Vetter Subject: Re: [linux-sunxi] [PATCH 1/3] Revert "drm/sun4i: dsi: Change the start delay calculation" Message-ID: <20191003133447.yh2qcaazn2blphoo@gilmour> References: <20191001080253.6135-1-icenowy@aosc.io> <20191001080253.6135-2-icenowy@aosc.io> <20191003131916.4bm22krapo5tz6oz@gilmour> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ahbpm7frntnvtdny" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ahbpm7frntnvtdny Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 03, 2019 at 09:21:30PM +0800, Icenowy Zheng wrote: > > > =E4=BA=8E 2019=E5=B9=B410=E6=9C=883=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=88= 9:19:16, Maxime Ripard =E5=86=99=E5=88=B0: > >On Thu, Oct 03, 2019 at 12:38:43PM +0530, Jagan Teki wrote: > >> On Tue, Oct 1, 2019 at 1:33 PM Icenowy Zheng wrote: > >> > > >> > This reverts commit da676c6aa6413d59ab0a80c97bbc273025e640b2. > >> > > >> > The original commit adds a start parameter to the calculation of > >the > >> > start delay according to some old BSP versions from Allwinner. > >However, > >> > there're two ways to add this delay -- add it in DSI controller or > >add > >> > it in the TCON. Add it in both controllers won't work. > >> > > >> > The code before this commit is picked from new versions of BSP > >kernel, > >> > which has a comment for the 1 that says "put start_delay to tcon". > >By > >> > checking the sun4i_tcon0_mode_set_cpu() in sun4i_tcon driver, it > >has > >> > already added this delay, so we shouldn't repeat to add the delay > >in DSI > >> > controller, otherwise the timing won't match. > >> > >> Thanks for this change. look like this is proper reason for adding + > >> 1. also adding bsp code links here might help for future reference. > >> > >> Otherwise, > >> > >> Reviewed-by: Jagan Teki > > > >The commit log was better in this one. I ended up merging this one, > >with your R-b. > > Please note that Jagan's v11 3/7 is still needed. Right, unfortunately, it doesn't apply anymore. Jagan, can you send that patch rebased? Thanks! Maxime --ahbpm7frntnvtdny Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXZX49wAKCRDj7w1vZxhR xXlJAP9eYpRWg54xgD3SVv2/I+5gd0AAON4A7dZdtgu+5/pTPQD+PCU1uq8t/VDH usW3Bq24a2WrKYQM+3lOWKH7WkUhnA4= =hN/o -----END PGP SIGNATURE----- --ahbpm7frntnvtdny--