From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F64C10F14 for ; Thu, 3 Oct 2019 16:13:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DE522054F for ; Thu, 3 Oct 2019 16:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119234; bh=k1efsW7IKJq+Czkbunuurx0HI92kzse705DoNbejggo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YThPCRUOmUnOKflHwJUEF43EnkBEh2CbVYp4wJdoZ/bgoud7yAprhYaT6HVeEQx2W pu6Pxtg4HpzqotlD455UrxeWf3GjM1FOTkWbg6NtMywXuhw8AnA5EKXA/pqiPnrbJs 1NVzDkTI06Hzn6Gak7uWDOqsdA5SOKl5l+JkOA+o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388466AbfJCQNx (ORCPT ); Thu, 3 Oct 2019 12:13:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:36796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388449AbfJCQNv (ORCPT ); Thu, 3 Oct 2019 12:13:51 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 60E1C2054F; Thu, 3 Oct 2019 16:13:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119230; bh=k1efsW7IKJq+Czkbunuurx0HI92kzse705DoNbejggo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=06s1Z8wxzDDQN7U71M1I7KVY4jkrrJFQug1uGQEJcqZIsgdDX+IYMSrFOoUGV7RG3 NnIAtBG8UGVSdUIaJRHY1lwLOFpIYM3uqC2Z14kr0xlvrjaOVTuw8L9cbY9zA7UCQb LvCzdkHT+Fqd0yLU2wvrStK8op7qutoX5eeLchd0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rakesh Pandit , Theodore Tso , stable@kernel.org Subject: [PATCH 4.14 175/185] ext4: fix warning inside ext4_convert_unwritten_extents_endio Date: Thu, 3 Oct 2019 17:54:13 +0200 Message-Id: <20191003154520.560757088@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154437.541662648@linuxfoundation.org> References: <20191003154437.541662648@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rakesh Pandit commit e3d550c2c4f2f3dba469bc3c4b83d9332b4e99e1 upstream. Really enable warning when CONFIG_EXT4_DEBUG is set and fix missing first argument. This was introduced in commit ff95ec22cd7f ("ext4: add warning to ext4_convert_unwritten_extents_endio") and splitting extents inside endio would trigger it. Fixes: ff95ec22cd7f ("ext4: add warning to ext4_convert_unwritten_extents_endio") Signed-off-by: Rakesh Pandit Signed-off-by: Theodore Ts'o Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/extents.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -3756,8 +3756,8 @@ static int ext4_convert_unwritten_extent * illegal. */ if (ee_block != map->m_lblk || ee_len > map->m_len) { -#ifdef EXT4_DEBUG - ext4_warning("Inode (%ld) finished: extent logical block %llu," +#ifdef CONFIG_EXT4_DEBUG + ext4_warning(inode->i_sb, "Inode (%ld) finished: extent logical block %llu," " len %u; IO logical block %llu, len %u", inode->i_ino, (unsigned long long)ee_block, ee_len, (unsigned long long)map->m_lblk, map->m_len);