From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D1B2C32792 for ; Thu, 3 Oct 2019 16:23:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E14321A4C for ; Thu, 3 Oct 2019 16:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119824; bh=qvdiACbPD+9kE/AR44QPMyH4ycwkChBkxIkwGFZfNfE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=EGhm5fQhAIYgLQgyCh+YWo8YlDUn5e/Ap+N2Fmt64v4wWIXbApt32J/ZLkFaQ5WRJ LLe4PuS2Ybng42gjuxomcpJnh08J67vJX8207VNok7RXnkcya78qMDnRjYWkPy4Af4 TbRPiWWKUFljKinaZYJb6vQdzS+a3pfrEYyijGE0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390617AbfJCQXn (ORCPT ); Thu, 3 Oct 2019 12:23:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:52776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389355AbfJCQXi (ORCPT ); Thu, 3 Oct 2019 12:23:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9CBA222BE; Thu, 3 Oct 2019 16:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119818; bh=qvdiACbPD+9kE/AR44QPMyH4ycwkChBkxIkwGFZfNfE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VVAK34sI8S26qudXij7RD930DG62bPLW6YNQzL/d6KU9fiOszR4SzAjXz+nxI0YTC VGa66HJh/AOMO1UpJMlyoD35A2Wgc2g/vSZG2OIehgw+9AyVus8TgOWHgCrIjHRZ75 IqitFMzPRuFtTGQ756S90al6etFmfbCu7eYaq/rc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chien Nguyen , Chris Brandt , Wolfram Sang Subject: [PATCH 4.19 205/211] i2c: riic: Clear NACK in tend isr Date: Thu, 3 Oct 2019 17:54:31 +0200 Message-Id: <20191003154530.219914681@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154447.010950442@linuxfoundation.org> References: <20191003154447.010950442@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chris Brandt commit a71e2ac1f32097fbb2beab098687a7a95c84543e upstream. The NACKF flag should be cleared in INTRIICNAKI interrupt processing as description in HW manual. This issue shows up quickly when PREEMPT_RT is applied and a device is probed that is not plugged in (like a touchscreen controller). The result is endless interrupts that halt system boot. Fixes: 310c18a41450 ("i2c: riic: add driver") Cc: stable@vger.kernel.org Reported-by: Chien Nguyen Signed-off-by: Chris Brandt Signed-off-by: Wolfram Sang Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/busses/i2c-riic.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/i2c/busses/i2c-riic.c +++ b/drivers/i2c/busses/i2c-riic.c @@ -203,6 +203,7 @@ static irqreturn_t riic_tend_isr(int irq if (readb(riic->base + RIIC_ICSR2) & ICSR2_NACKF) { /* We got a NACKIE */ readb(riic->base + RIIC_ICDRR); /* dummy read */ + riic_clear_set_bit(riic, ICSR2_NACKF, 0, RIIC_ICSR2); riic->err = -ENXIO; } else if (riic->bytes_left) { return IRQ_NONE;