From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD195C32792 for ; Thu, 3 Oct 2019 19:53:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D6762133F for ; Thu, 3 Oct 2019 19:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570132380; bh=UcnOy/rJUGALOoVZI1BUFqQgEVaBFlIv9avHKWpI+mA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=sWrlIYtfZ4re1vzjPiV67UIikF1wK0lzUVp63SCqEgISK9lBqtcT4No6eHfdLRl8c xxNb25rc7oOhGRrblmhc91M2so1jgne26OuXZfW9CgkNJ5oZvYYRnAJVRtrrjK9Fun /CIBPT6LEhkht8KitbgT1dBXvxfO7/waCKmowRIQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387654AbfJCTw7 (ORCPT ); Thu, 3 Oct 2019 15:52:59 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:44540 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726677AbfJCTw7 (ORCPT ); Thu, 3 Oct 2019 15:52:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1yFNFXuAcr496RCSAiHWQcK6F/VRk+66pua7RRYRJMM=; b=XztyqVSJvQb1FIWeXD0gf0BRW CBmTggGyeketQtpqlyVx6EgxS3c3KBE9WTmWrvPC4auRg+VM2tZXqY5KahRI/r2LRKWMrPlv4voHK 113OvYWO1Z/5CdzEiGqORrsdIzsIzE5Ue7bu8ksGIMmP50jrZm08OpRQQ4IzElU5l36GxCG9PAZ56 PT6WrrNjRRkqf/UZwoa8Jr+DtnvFVaMpOE4+/ZexTHEBq/3Gcu5odOmT4jNKywSDqRn8g9ZRhzwgM StAdsHab1gIrxocn8qy5q7X0YQcyrpqkqBO1Lf8XQmAnhU5dZTwEvG2zSeJjM06bptX9U7vBBe/O3 hnGrBNuYw==; Received: from 177.133.68.49.dynamic.adsl.gvt.net.br ([177.133.68.49] helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1iG79k-0007gZ-DP; Thu, 03 Oct 2019 19:52:56 +0000 Date: Thu, 3 Oct 2019 16:52:52 -0300 From: Mauro Carvalho Chehab To: Gonsolo Cc: JP , crope@iki.fi, Sean Young , linux-media@vger.kernel.org, Linux Kernel Subject: Re: [PATCH] si2157: Add support for Logilink VG0022A. Message-ID: <20191003165252.4145accf@coco.lan> In-Reply-To: References: <29ab2e43-4374-a3ea-6ae1-a4267867eaa4@jpvw.nl> <20191002154922.7f1cfc76@coco.lan> <20191003080539.2b13c03b@coco.lan> <20191003120238.75811da6@coco.lan> <20191003160336.GA5125@Limone> <20191003130909.01d29b77@coco.lan> <20191003162326.GA2727@Limone> <20191003144225.0137bf6c@coco.lan> <20191003183200.GA2631@Limone> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, 3 Oct 2019 21:40:28 +0200 Gonsolo escreveu: > From si2168.c:808: > /* Sometimes firmware returns bogus value */ > if (utmp1 == 0xffff) > utmp1 = 0; Huh? are you using the upstream Kernel? the above code is at line 215! Please always use the upstream code when sending patches. > > Maybe we can include my "bogus" hack to get at least Logilink running. > Maybe with an info message to tell users what is going on. > > g Thanks, Mauro