From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13A3BC10F14 for ; Thu, 3 Oct 2019 20:03:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8B1E2086A for ; Thu, 3 Oct 2019 20:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570133017; bh=7Oo5hWD0LETHjpa4M/vFGAAxoiJsx74spei137iez1c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=2FZuA2indhKMidroHYPlSlGIVWmAE3cYMbVh4jNViQrn+BYYfoWQaO4BvktBaht8m AaGBJatLGegeo7z+CVUh7ILzpZvM2Rx5yByGwv5RahOMRR/BKGxqV68QPKDW/fKKO7 KtxC/W9TJNo2J14/UA+7IBqM0yJN3HZr/hUpK+CU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388114AbfJCUDh (ORCPT ); Thu, 3 Oct 2019 16:03:37 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:47496 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731089AbfJCUDg (ORCPT ); Thu, 3 Oct 2019 16:03:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=z1XgSOD9JUAI9XDkqQ6D+Ysfh47QMU7fl9qU7PgVOQ0=; b=tFvV6H25hxwBagX4z6u5oU9N2 BAIgMAeCiNI9ZuhPWLU15oYPeU6gHt41w60RAOEjCWgHbZugkd9d29b2qN6Pzyi3pE05ZYQo3qAIp WNp9GzrnbusegdRfzDJ+87KrD/l2Qegb+2QR7S2ZjnHtecdY8MWe8mabojw0ILDe+G40bjKuPQrj9 VMlO6QVnvsc0ndDlIt19X/IuLxEWHy1THgeANhU7pVPQwU+XRnCnyO5QjuIP800CCdyE5JdIHEg4W 2cYWqlVdns14+ss2LvZOIYPPhBwOFTfbip5GNFg7cF0E7Mte7IO4mntJxEk5sHotd3n5HNUdptAPb sZ09+2ZEw==; Received: from 177.133.68.49.dynamic.adsl.gvt.net.br ([177.133.68.49] helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1iG7K1-00036T-EB; Thu, 03 Oct 2019 20:03:33 +0000 Date: Thu, 3 Oct 2019 17:03:29 -0300 From: Mauro Carvalho Chehab To: Gonsolo Cc: JP , crope@iki.fi, Sean Young , linux-media@vger.kernel.org, Linux Kernel Subject: Re: [PATCH] si2157: Add support for Logilink VG0022A. Message-ID: <20191003170329.3624f7f2@coco.lan> In-Reply-To: References: <29ab2e43-4374-a3ea-6ae1-a4267867eaa4@jpvw.nl> <20191002154922.7f1cfc76@coco.lan> <20191003080539.2b13c03b@coco.lan> <20191003120238.75811da6@coco.lan> <20191003160336.GA5125@Limone> <20191003130909.01d29b77@coco.lan> <20191003162326.GA2727@Limone> <20191003144225.0137bf6c@coco.lan> <20191003183200.GA2631@Limone> <20191003163914.7c384d36@coco.lan> <20191003164426.6da8538f@coco.lan> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, 3 Oct 2019 21:51:35 +0200 Gonsolo escreveu: > > 1) The firmware file is likely at the Windows driver for this device > > (probably using a different format). It should be possible to get > > it from there. > > If you tell me how I'm willing to do this. :) I don't know. I was not the one that extracted the firmware. I guess Antti did it. I suspect that there are some comments about that in the past at the ML. seek at lore.kernel.org. > > > 2) Another possibility would be to add a way to tell the si2168 driver > > to not try to load a firmware, using the original one. That would > > require adding a field at si2168_config to allow signalizing to it > > that it should not try to load a firmware file, and add a quirk at > > the af9035 that would set such flag for Logilink VG0022A. > > I don't get this. Which firmware, si2168 or si2157? The one that it is causing the problem. If I understood well, the culprit was the si2168 firmware. > I'm still for option 3: If there is a bogus chip revision number it's > likely the VG0022A and we can safely set fw to NULL, in which case > everything works. > All already working devices will continue to work as before. > With a low probability there are other devices that will return 0xffff > but a) they didn't work until now and b) they receive a clear message > that they return bogus numbers and this works just for the VG0022A, in > which case this hardware can be tested. > At last, *my* VG0022A will work without a custom kernel which I'm a > big fan of. :)) > > Are there any counterarguments except that it is not the cleanest > solution in the universe? ;) That's a really bad solution. Returning 0xff is what happens when things go wrong during I2C transfers. Several problems can cause it, including device misfunction. Every time someone comes with a patch trying to ignore it, things go sideways for other devices (existing or future ones). Ignoring errors is always a bad idea. Also, it is a very bad idea to load a firmware that it is not compatible with a device. There are even cases of devices that were burned due to that[1]. [1] XCeive has two versions of 3028/2028 chipsets. One with a "normal power" and a "low power" version. If the firmware for the "normal power" (version 2.7) is used at the "low power" chip (with requires version 3.6), it makes the chipset hotter and reduces a lot the lifetime of the tuner. Thanks, Mauro