From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE64C4CED1 for ; Fri, 4 Oct 2019 09:16:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9113C215EA for ; Fri, 4 Oct 2019 09:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731322AbfJDJQL (ORCPT ); Fri, 4 Oct 2019 05:16:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59866 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730179AbfJDJQK (ORCPT ); Fri, 4 Oct 2019 05:16:10 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2279619D335 for ; Fri, 4 Oct 2019 09:16:10 +0000 (UTC) Received: by mail-wr1-f72.google.com with SMTP id z1so2407348wrw.21 for ; Fri, 04 Oct 2019 02:16:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hhPEpgLhkjexE7wGXfmiyqeRzNcW/U3S79ip8ewXhIg=; b=lSfI3CFHUqE09oGBAvvfmgnhc1EmU5IB+D//P63BTMY2JMKotTEMTpywV5QNDieNgY Nyya6IbX19U0MKGoAHcu5g3QnRynu/3kHRcekNo2mKtZG7QFglp7ahXUIYGhWWXfNc1w SrEE8fvGg5mzTCeAQjm83RlWlqyXoaPB9geEAo+w1JPM6QjWr0nNPPDXw91x4b7NjIhd frCEVWXhCPjMic7oucqfYZCnz5BbdW90WBRoWS4RB6V5tAItExrjFblM/9G1IkCOp6PP f9CIUzILob9zWhOqDUz3zky5PfwSN4HHEouXqNTrUYrUXjCzdbrqwm/HeoUD9M1fkAtq UH/A== X-Gm-Message-State: APjAAAX3fQ9ZIySHpvFFT4Y60UI9Na8UH7iIexYVsWOnpywhSXyPdCAD ++aWb1765osKkYAWNw2plzopD777CNdHF622ZLmjgwWKCFFRg0UDmBjuQ3pIEe8RDDEhy/TROhd L76RBzNtfKUmuEfM4WoHWA2Co X-Received: by 2002:a1c:9d15:: with SMTP id g21mr10287386wme.96.1570180568813; Fri, 04 Oct 2019 02:16:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqwYyFXc0psA9cM79xGyuf3QCE7kgh2CziA2e0KZxOqK4U+Rh82+kx6tnfpcYC/+KSgegIYtMA== X-Received: by 2002:a1c:9d15:: with SMTP id g21mr10287358wme.96.1570180568530; Fri, 04 Oct 2019 02:16:08 -0700 (PDT) Received: from steredhat (host174-200-dynamic.52-79-r.retail.telecomitalia.it. [79.52.200.174]) by smtp.gmail.com with ESMTPSA id q192sm7660110wme.23.2019.10.04.02.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2019 02:16:07 -0700 (PDT) Date: Fri, 4 Oct 2019 11:16:05 +0200 From: Stefano Garzarella To: Dexuan Cui Cc: "netdev@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , KY Srinivasan , Stefan Hajnoczi , Sasha Levin , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "David S. Miller" , "virtualization@lists.linux-foundation.org" , Stephen Hemminger , Jason Wang , "Michael S. Tsirkin" , Haiyang Zhang , Jorgen Hansen Subject: Re: [RFC PATCH 00/13] vsock: add multi-transports support Message-ID: <20191004091605.ayed7iqjhurzrdap@steredhat> References: <20190927112703.17745-1-sgarzare@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 04, 2019 at 12:04:46AM +0000, Dexuan Cui wrote: > > From: Stefano Garzarella > > Sent: Friday, September 27, 2019 4:27 AM > > ... > > Patch 9 changes the hvs_remote_addr_init(). setting the > > VMADDR_CID_HOST as remote CID instead of VMADDR_CID_ANY to make > > the choice of transport to be used work properly. > > @Dexuan Could this change break anything? > > This patch looks good to me. > Thank you very much for your reviews! > > @Dexuan please can you test on HyperV that I didn't break anything > > even without nested VMs? > > I did some quick tests with the 13 patches in a Linux VM (this is not > a nested VM) on Hyper-V and it looks nothing is broken. :-) > Great :-) > > I'll try to setup a Windows host where to test the nested VMs > > I suppose you're going to run a Linux VM on a Hyper-V host, > and the Linux VM itself runs KVM/VmWare so it can create its own child > VMs. IMO this is similar to the test "nested KVM ( ..., virtio-transport[L1,L2]" > you have done. Yes, I think so. If the Hyper-V transport works well without nested VM, it should work the same with a nested KVM/VMware. Thanks, Stefano