From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B372BC4360C for ; Fri, 4 Oct 2019 15:30:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B327222CC for ; Fri, 4 Oct 2019 15:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389812AbfJDPai (ORCPT ); Fri, 4 Oct 2019 11:30:38 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:42392 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389086AbfJDPai (ORCPT ); Fri, 4 Oct 2019 11:30:38 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1iGPWu-0000ro-GG; Sat, 05 Oct 2019 01:30:05 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sat, 05 Oct 2019 01:29:56 +1000 Date: Sat, 5 Oct 2019 01:29:56 +1000 From: Herbert Xu To: Tomer Maimon Cc: mpm@selenic.com, arnd@arndb.de, gregkh@linuxfoundation.org, robh+dt@kernel.org, mark.rutland@arm.com, avifishman70@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, sumit.garg@linaro.org, jens.wiklander@linaro.org, vkoul@kernel.org, tglx@linutronix.de, joel@jms.id.au, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH v3 0/2] hwrng: npcm: add NPCM RNG driver support Message-ID: <20191004152956.GE5148@gondor.apana.org.au> References: <20190912090149.7521-1-tmaimon77@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190912090149.7521-1-tmaimon77@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 12, 2019 at 12:01:47PM +0300, Tomer Maimon wrote: > This patch set adds Random Number Generator (RNG) support > for the Nuvoton NPCM Baseboard Management Controller (BMC). > > The RNG driver we use power consumption when the RNG > is not required. > > The NPCM RNG driver tested on NPCM750 evaluation board. > > Addressed comments from:. > - Daniel Thompson: https://lkml.org/lkml/2019/9/10/352 > - Milton Miller II : https://lkml.org/lkml/2019/9/10/847 > - Daniel Thompson: https://lkml.org/lkml/2019/9/10/294 > > Changes since version 2: > - Rearrange wait parameter in npcm_rng_read function. > - Calling pm_runtime_enable function before hwrng_register function > called to enable the hwrng before add_early_randomness called. > - Remove quality dt-binding parameter in the driver and documentation. > - Disable CONFIG_PM if devm_hwrng_register failed. > - Remove owner setting in the driver struct. > > Changes since version 1: > - Define timout in real-world units. > - Using readl_poll_timeout in rng_read function. > - Honor wait parameter in rng_read function. > - Using local variable instead of #ifndef. > - Remove probe print. > > Tomer Maimon (2): > dt-binding: hwrng: add NPCM RNG documentation > hwrng: npcm: add NPCM RNG driver > > .../bindings/rng/nuvoton,npcm-rng.txt | 12 ++ > drivers/char/hw_random/Kconfig | 13 ++ > drivers/char/hw_random/Makefile | 1 + > drivers/char/hw_random/npcm-rng.c | 186 ++++++++++++++++++ > 4 files changed, 212 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt > create mode 100644 drivers/char/hw_random/npcm-rng.c All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt