From: Matthew Wilcox <willy@infradead.org>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
jglisse@redhat.com, mike.kravetz@oracle.com, riel@surriel.com,
khlebnikov@yandex-team.ru, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/rmap.c: reuse mergeable anon_vma as parent when fork
Date: Fri, 4 Oct 2019 18:15:54 -0700 [thread overview]
Message-ID: <20191005011554.GQ32665@bombadil.infradead.org> (raw)
In-Reply-To: <20191004234845.GB15415@richard>
On Sat, Oct 05, 2019 at 07:48:45AM +0800, Wei Yang wrote:
> On Fri, Oct 04, 2019 at 09:11:20AM -0700, Matthew Wilcox wrote:
> >On Sat, Oct 05, 2019 at 12:06:32AM +0800, Wei Yang wrote:
> >> After this change, kernel build test reduces 20% anon_vma allocation.
> >
> >But does it have any effect on elapsed time or peak memory consumption?
>
> Do the same kernel build test and record time:
>
>
> Origin
>
> real 2m50.467s
> user 17m52.002s
> sys 1m51.953s
>
> real 2m48.662s
> user 17m55.464s
> sys 1m50.553s
>
> real 2m51.143s
> user 17m59.687s
> sys 1m53.600s
>
>
> Patched
>
> real 2m43.733s
> user 17m25.705s
> sys 1m41.791s
>
> real 2m47.146s
> user 17m47.451s
> sys 1m43.474s
>
> real 2m45.763s
> user 17m38.230s
> sys 1m42.102s
>
>
> For time in sys, it reduced 8.5%.
That's compelling!
next prev parent reply other threads:[~2019-10-05 1:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 16:06 [PATCH] mm/rmap.c: reuse mergeable anon_vma as parent when fork Wei Yang
2019-10-04 16:11 ` Matthew Wilcox
2019-10-04 22:33 ` Wei Yang
2019-10-04 23:48 ` Wei Yang
2019-10-05 1:15 ` Matthew Wilcox [this message]
2019-10-05 12:35 ` Wei Yang
2019-10-04 16:33 ` Konstantin Khlebnikov
2019-10-04 22:38 ` Wei Yang
2019-10-04 23:45 ` Rik van Riel
2019-10-04 23:49 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005011554.GQ32665@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jglisse@redhat.com \
--cc=khlebnikov@yandex-team.ru \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=richardw.yang@linux.intel.com \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).