From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Ding Xiang <dingxiang@cmss.chinamobile.com>
Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remoteproc: debug: Remove unneeded NULL check
Date: Fri, 4 Oct 2019 21:12:08 -0700 [thread overview]
Message-ID: <20191005041208.GE5189@tuxbook-pro> (raw)
In-Reply-To: <1569293934-31451-1-git-send-email-dingxiang@cmss.chinamobile.com>
On Mon 23 Sep 19:58 PDT 2019, Ding Xiang wrote:
> debugfs_remove_recursive will do NULL check, so remove
> the redundant null check
>
Nice, applied.
Regards,
Bjorn
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
> drivers/remoteproc/remoteproc_debugfs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
> index 8cd4a0a..dd93cf0 100644
> --- a/drivers/remoteproc/remoteproc_debugfs.c
> +++ b/drivers/remoteproc/remoteproc_debugfs.c
> @@ -333,9 +333,6 @@ struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc,
>
> void rproc_delete_debug_dir(struct rproc *rproc)
> {
> - if (!rproc->dbg_dir)
> - return;
> -
> debugfs_remove_recursive(rproc->dbg_dir);
> }
>
> --
> 1.9.1
>
>
>
prev parent reply other threads:[~2019-10-05 4:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 2:58 [PATCH] remoteproc: debug: Remove unneeded NULL check Ding Xiang
2019-10-05 4:12 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005041208.GE5189@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=dingxiang@cmss.chinamobile.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).