From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14724C47404 for ; Sun, 6 Oct 2019 01:22:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7EA2222CB for ; Sun, 6 Oct 2019 01:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570324930; bh=lg1rcaPaYzlWfGFd7qFkTdrWx6pX1IzDsEq3GfuVM7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kLBxYervr34E38aqAnkeC01KuCt2AeWZ3rT8iYQNNOA82TXOB8zGnjGETUQoEBqxi 4y8bHkIdsZ1t2rHkpyJiUiVeY+OLwVzS/yAq5ThHm/26/Qtsy+Gn8Sc01mI5Mb8DLr mqyIuqFq9F5/a8ORaKhniOqmmSWYjfyTwpnwosE0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727039AbfJFBWK (ORCPT ); Sat, 5 Oct 2019 21:22:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:51946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726956AbfJFBWJ (ORCPT ); Sat, 5 Oct 2019 21:22:09 -0400 Received: from dragon (li937-157.members.linode.com [45.56.119.157]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84B3A222C8; Sun, 6 Oct 2019 01:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570324929; bh=lg1rcaPaYzlWfGFd7qFkTdrWx6pX1IzDsEq3GfuVM7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tKSRDosiWc8MJ8AXoLQ4RxgA03z9u8Yw/Mbw9HgGxtf+SR359QrHrFv5dG332rVLh rcNM/S4ZtrviI1Kjak/neKKCbN2JsuXaLNiTIgzaa6N4Mt78oYPERAX1oHpmBvVY9G ePT4hYVqeBXGDU6yEJga2m5VXaHZ7DI4UiahDyF8= Date: Sun, 6 Oct 2019 09:21:51 +0800 From: Shawn Guo To: Anson Huang Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, daniel.baluta@nxp.com, aisheng.dong@nxp.com, abel.vesa@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH] soc: imx: imx-scu: Getting UID from SCU should have response Message-ID: <20191006012149.GI7150@dragon> References: <1567624394-25023-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1567624394-25023-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 04, 2019 at 03:13:14PM -0400, Anson Huang wrote: > The SCU firmware API for getting UID should have response, > otherwise, the message stored in function stack could be > released and then the response data received from SCU will be > stored into that released stack and cause kernel NULL pointer > dump. > > Fixes: 73feb4d0f8f1 ("soc: imx-scu: Add SoC UID(unique identifier) support") > Signed-off-by: Anson Huang Applied, thanks.