From: Wei Yang <richardw.yang@linux.intel.com>
To: akpm@linux-foundation.org, mgorman@techsingularity.net,
vbabka@suse.cz, osalvador@suse.de, hch@infradead.org,
willy@infradead.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wei Yang <richardw.yang@linux.intel.com>
Subject: [Patch v2 2/3] mm/mmap.c: __vma_unlink_prev is not necessary now
Date: Sun, 6 Oct 2019 09:26:35 +0800 [thread overview]
Message-ID: <20191006012636.31521-2-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20191006012636.31521-1-richardw.yang@linux.intel.com>
The third parameter of __vma_unlink_common could differentiate these two
types. __vma_unlink_prev is not necessary now.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
v2: rebase on top of 5.4-rc1
---
mm/mmap.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index c61403f25833..2ca805209c47 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -702,13 +702,6 @@ static __always_inline void __vma_unlink_common(struct mm_struct *mm,
vmacache_invalidate(mm);
}
-static inline void __vma_unlink_prev(struct mm_struct *mm,
- struct vm_area_struct *vma,
- struct vm_area_struct *prev)
-{
- __vma_unlink_common(mm, vma, vma);
-}
-
/*
* We cannot adjust vm_start, vm_end, vm_pgoff fields of a vma that
* is already present in an i_mmap tree without adjusting the tree.
@@ -883,7 +876,7 @@ int __vma_adjust(struct vm_area_struct *vma, unsigned long start,
* us to remove next before dropping the locks.
*/
if (remove_next != 3)
- __vma_unlink_prev(mm, next, vma);
+ __vma_unlink_common(mm, next, next);
else
/*
* vma is not before next if they've been
--
2.17.1
next prev parent reply other threads:[~2019-10-06 1:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 1:26 [Patch v2 1/3] mm/mmap.c: prev could be retrieved from vma->vm_prev Wei Yang
2019-10-06 1:26 ` Wei Yang [this message]
2019-10-06 1:26 ` [Patch v2 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006012636.31521-2-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).