From: Shawn Guo <shawnguo@kernel.org>
To: Stefan-gabriel Mirea <stefan-gabriel.mirea@nxp.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>, Leo Li <leoyang.li@nxp.com>,
"jslaby@suse.com" <jslaby@suse.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 3/6] serial: fsl_linflexuart: Be consistent with the name
Date: Sun, 6 Oct 2019 09:56:50 +0800 [thread overview]
Message-ID: <20191006015647.GJ7150@dragon> (raw)
In-Reply-To: <20190905115803.19565-4-stefan-gabriel.mirea@nxp.com>
On Thu, Sep 05, 2019 at 11:58:36AM +0000, Stefan-gabriel Mirea wrote:
> For consistency reasons, spell the controller name as "LINFlexD" in
> comments and documentation.
>
> Signed-off-by: Stefan-Gabriel Mirea <stefan-gabriel.mirea@nxp.com>
Hi Greg,
The series looks good to me. I assume that you will take this patch
and #5.
Shawn
> ---
> Documentation/admin-guide/kernel-parameters.txt | 2 +-
> drivers/tty/serial/Kconfig | 8 ++++----
> drivers/tty/serial/fsl_linflexuart.c | 4 ++--
> include/uapi/linux/serial_core.h | 4 ++--
> 4 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 614012a61754..23162492ea2f 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1091,7 +1091,7 @@
> mapped with the correct attributes.
>
> linflex,<addr>
> - Use early console provided by Freescale LinFlex UART
> + Use early console provided by Freescale LINFlexD UART
> serial driver for NXP S32V234 SoCs. A valid base
> address must be provided, and the serial port must
> already be setup and configured.
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index b658589208bf..2d5115375345 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1434,19 +1434,19 @@ config SERIAL_FSL_LPUART_CONSOLE
> you can make it the console by answering Y to this option.
>
> config SERIAL_FSL_LINFLEXUART
> - tristate "Freescale linflexuart serial port support"
> + tristate "Freescale LINFlexD UART serial port support"
> depends on PRINTK
> select SERIAL_CORE
> help
> - Support for the on-chip linflexuart on some Freescale SOCs.
> + Support for the on-chip LINFlexD UART on some Freescale SOCs.
>
> config SERIAL_FSL_LINFLEXUART_CONSOLE
> - bool "Console on Freescale linflexuart serial port"
> + bool "Console on Freescale LINFlexD UART serial port"
> depends on SERIAL_FSL_LINFLEXUART=y
> select SERIAL_CORE_CONSOLE
> select SERIAL_EARLYCON
> help
> - If you have enabled the linflexuart serial port on the Freescale
> + If you have enabled the LINFlexD UART serial port on the Freescale
> SoCs, you can make it the console by answering Y to this option.
>
> config SERIAL_CONEXANT_DIGICOLOR
> diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
> index 26b9601a0952..ca90551384ca 100644
> --- a/drivers/tty/serial/fsl_linflexuart.c
> +++ b/drivers/tty/serial/fsl_linflexuart.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * Freescale linflexuart serial port driver
> + * Freescale LINFlexD UART serial port driver
> *
> * Copyright 2012-2016 Freescale Semiconductor, Inc.
> * Copyright 2017-2018 NXP
> @@ -938,5 +938,5 @@ static void __exit linflex_serial_exit(void)
> module_init(linflex_serial_init);
> module_exit(linflex_serial_exit);
>
> -MODULE_DESCRIPTION("Freescale linflex serial port driver");
> +MODULE_DESCRIPTION("Freescale LINFlexD serial port driver");
> MODULE_LICENSE("GPL v2");
> diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
> index 63fa56b899e8..26967c2f4a4f 100644
> --- a/include/uapi/linux/serial_core.h
> +++ b/include/uapi/linux/serial_core.h
> @@ -293,7 +293,7 @@
> /* Sunix UART */
> #define PORT_SUNIX 121
>
> -/* Freescale Linflex UART */
> -#define PORT_LINFLEXUART 121
> +/* Freescale LINFlexD UART */
> +#define PORT_LINFLEXUART 122
>
> #endif /* _UAPILINUX_SERIAL_CORE_H */
> --
> 2.22.0
>
next prev parent reply other threads:[~2019-10-06 1:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 11:58 [PATCH v4 0/6] Add initial support for S32V234-EVB Stefan-gabriel Mirea
2019-09-05 11:58 ` [PATCH v4 1/6] dt-bindings: arm: fsl: Add the S32V234-EVB board Stefan-gabriel Mirea
2019-10-06 1:59 ` Shawn Guo
2019-10-07 12:24 ` Stefan-gabriel Mirea
2019-09-05 11:58 ` [PATCH v4 2/6] arm64: Introduce config for S32 Stefan-gabriel Mirea
2019-09-05 11:58 ` [PATCH v4 3/6] serial: fsl_linflexuart: Be consistent with the name Stefan-gabriel Mirea
2019-10-06 1:56 ` Shawn Guo [this message]
2019-09-05 11:58 ` [PATCH v4 4/6] arm64: dts: fsl: Add device tree for S32V234-EVB Stefan-gabriel Mirea
2019-09-05 11:58 ` [PATCH v4 5/6] dt-bindings: serial: Document Freescale LINFlexD UART Stefan-gabriel Mirea
2019-09-05 11:58 ` [PATCH v4 6/6] arm64: defconfig: Enable configs for S32V234 Stefan-gabriel Mirea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006015647.GJ7150@dragon \
--to=shawnguo@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=stefan-gabriel.mirea@nxp.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).