From: kbuild test robot <lkp@intel.com>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: kbuild-all@01.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, akpm@linux-foundation.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, andriy.shevchenko@linux.intel.com,
linux@rasmusvillemoes.dk, yamada.masahiro@socionext.com,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
geert@linux-m68k.org, preid@electromag.com.au, lukas@wunner.de,
sean.nyekjaer@prevas.dk, morten.tiljeset@prevas.dk,
William Breathitt Gray <vilhelm.gray@gmail.com>,
Mathias Duckeck <m.duckeck@kunbus.de>
Subject: Re: [PATCH v15 13/14] gpio: max3191x: Utilize the for_each_set_clump8 macro
Date: Sun, 6 Oct 2019 07:26:10 +0800 [thread overview]
Message-ID: <201910060744.lgRuOOiw%lkp@intel.com> (raw)
In-Reply-To: <f07b6bb5619ea1365cc58266254a7b5be65a9082.1570299719.git.vilhelm.gray@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2770 bytes --]
Hi William,
I love your patch! Yet something to improve:
[auto build test ERROR on gpio/for-next]
[cannot apply to v5.4-rc1 next-20191004]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-for_each_set_clump8-macro/20191006-032112
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpio/gpio-max3191x.c: In function 'max3191x_get_multiple':
>> drivers/gpio/gpio-max3191x.c:258:31: error: 'offset' undeclared (first use in this function); did you mean 'off_t'?
bitmap_set_value8(bits, in, offset);
^~~~~~
off_t
drivers/gpio/gpio-max3191x.c:258:31: note: each undeclared identifier is reported only once for each function it appears in
vim +258 drivers/gpio/gpio-max3191x.c
231
232 static int max3191x_get_multiple(struct gpio_chip *gpio, unsigned long *mask,
233 unsigned long *bits)
234 {
235 struct max3191x_chip *max3191x = gpiochip_get_data(gpio);
236 const unsigned int wordlen = max3191x_wordlen(max3191x);
237 int ret;
238 unsigned long bit;
239 unsigned long gpio_mask;
240 unsigned long in;
241
242 mutex_lock(&max3191x->lock);
243 ret = max3191x_readout_locked(max3191x);
244 if (ret)
245 goto out_unlock;
246
247 bitmap_zero(bits, gpio->ngpio);
248 for_each_set_clump8(bit, gpio_mask, mask, gpio->ngpio) {
249 unsigned int chipnum = bit / MAX3191X_NGPIO;
250
251 if (max3191x_chip_is_faulting(max3191x, chipnum)) {
252 ret = -EIO;
253 goto out_unlock;
254 }
255
256 in = ((u8 *)max3191x->xfer.rx_buf)[chipnum * wordlen];
257 in &= gpio_mask;
> 258 bitmap_set_value8(bits, in, offset);
259 }
260
261 out_unlock:
262 mutex_unlock(&max3191x->lock);
263 return ret;
264 }
265
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54933 bytes --]
next prev parent reply other threads:[~2019-10-05 23:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 18:36 [PATCH v15 00/14] Introduce the for_each_set_clump8 macro William Breathitt Gray
2019-10-05 18:36 ` [PATCH v15 01/14] bitops: " William Breathitt Gray
2019-10-09 9:25 ` Linus Walleij
2019-10-05 18:36 ` [PATCH v15 02/14] lib/test_bitmap.c: Add for_each_set_clump8 test cases William Breathitt Gray
2019-10-05 18:36 ` [PATCH v15 03/14] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro William Breathitt Gray
2019-10-05 18:36 ` [PATCH v15 04/14] gpio: 104-idi-48: " William Breathitt Gray
2019-10-05 18:36 ` [PATCH v15 05/14] gpio: gpio-mm: " William Breathitt Gray
2019-10-05 18:37 ` [PATCH v15 06/14] gpio: ws16c48: " William Breathitt Gray
2019-10-05 18:37 ` [PATCH v15 07/14] gpio: pci-idio-16: " William Breathitt Gray
2019-10-05 18:37 ` [PATCH v15 08/14] gpio: pcie-idio-24: " William Breathitt Gray
2019-10-05 18:37 ` [PATCH v15 09/14] gpio: uniphier: " William Breathitt Gray
2019-10-05 18:37 ` [PATCH v15 10/14] gpio: 74x164: Utilize the " William Breathitt Gray
2019-10-05 18:37 ` [PATCH v15 11/14] thermal: intel: intel_soc_dts_iosf: Utilize " William Breathitt Gray
2019-10-05 18:37 ` [PATCH v15 12/14] gpio: pisosr: Utilize the " William Breathitt Gray
2019-10-05 18:37 ` [PATCH v15 13/14] gpio: max3191x: " William Breathitt Gray
2019-10-05 23:26 ` kbuild test robot [this message]
2019-10-06 19:26 ` kbuild test robot
2019-10-05 18:37 ` [PATCH v15 14/14] gpio: pca953x: " William Breathitt Gray
2019-10-05 18:46 ` [PATCH v15 00/14] Introduce " William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910060744.lgRuOOiw%lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=geert@linux-m68k.org \
--cc=kbuild-all@01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lukas@wunner.de \
--cc=m.duckeck@kunbus.de \
--cc=morten.tiljeset@prevas.dk \
--cc=preid@electromag.com.au \
--cc=sean.nyekjaer@prevas.dk \
--cc=vilhelm.gray@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).