From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B3CC4360C for ; Sun, 6 Oct 2019 17:26:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C3F02087E for ; Sun, 6 Oct 2019 17:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570382790; bh=NpFt4VysNHZNSD9PF2n48smfBRcHUrmddrU3O6zZY+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=efKgsSwpvVXhV8m8WrHL3lCtUpsoLd+iBuTNdQ+46M4h67Ua74/mohknL6yJNIa4n oZf/bYnUb8/ch11JDme2R4di+9Mv017UmPF9YX4QMbgrVhkPfW4UVbQYldAuoC2Ia9 tZ0UPuHwHS4L1IdB5LHw5Z+322WEMlyCQF5aWDyU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728294AbfJFR03 (ORCPT ); Sun, 6 Oct 2019 13:26:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:51604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbfJFR01 (ORCPT ); Sun, 6 Oct 2019 13:26:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 263CA2077B; Sun, 6 Oct 2019 17:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570382786; bh=NpFt4VysNHZNSD9PF2n48smfBRcHUrmddrU3O6zZY+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yCak8zlGBbn2AaD9r7tcisQvp7J7fEevldpZkl4Z/6wxufe4ODvrs5aNJZttWKW6g NJVfZwlL9d4ifwPBRCzs12fxNkx5IIP1soNVlqwWIWOuSAyXxZnTVyui81qnXJCZHu 0R0R3UIbNmXjkYMdEo/sVfmnOumbks5f74t8m/mg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marko Kohtala , Mark Rutland , Rob Herring , Daniel Vetter , David Airlie , =?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?= , Bartlomiej Zolnierkiewicz , Sasha Levin Subject: [PATCH 4.14 06/68] video: ssd1307fb: Start page range at page_offset Date: Sun, 6 Oct 2019 19:20:42 +0200 Message-Id: <20191006171111.188642446@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006171108.150129403@linuxfoundation.org> References: <20191006171108.150129403@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marko Kohtala [ Upstream commit dd9782834dd9dde3624ff1acea8859f3d3e792d4 ] The page_offset was only applied to the end of the page range. This caused the display updates to cause a scrolling effect on the display because the amount of data written to the display did not match the range display expected. Fixes: 301bc0675b67 ("video: ssd1307fb: Make use of horizontal addressing mode") Signed-off-by: Marko Kohtala Cc: Mark Rutland Cc: Rob Herring Cc: Daniel Vetter Cc: David Airlie Cc: Michal Vokáč Signed-off-by: Bartlomiej Zolnierkiewicz Link: https://patchwork.freedesktop.org/patch/msgid/20190618074111.9309-4-marko.kohtala@okoko.fi Signed-off-by: Sasha Levin --- drivers/video/fbdev/ssd1307fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index f599520374ddf..5f7dbf1c46092 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -433,7 +433,7 @@ static int ssd1307fb_init(struct ssd1307fb_par *par) if (ret < 0) return ret; - ret = ssd1307fb_write_cmd(par->client, 0x0); + ret = ssd1307fb_write_cmd(par->client, par->page_offset); if (ret < 0) return ret; -- 2.20.1