From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B80B3C10F14 for ; Sun, 6 Oct 2019 17:34:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82FAA217F9 for ; Sun, 6 Oct 2019 17:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570383272; bh=ian+tWN6G0IstqirvWiqzGhkZLYP1MXNMkLKu3P74B8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2h+JPcrqB2m9aQUs+o/YXstF0esEENuJL9XxUa37BTBmXftp76qVkgf+JElhqqHQe EU55PMLwChoGCYtjQZuKCD+HH6Nh7sBzmbAVsVH3BbmQ7q3XH4rrYeBeYqj6F+Sy5q Z8ZeMJDr2biWr+BQXmVqbaRUfRQjxXfTfJZ53NtM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727300AbfJFReb (ORCPT ); Sun, 6 Oct 2019 13:34:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:33000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729949AbfJFReZ (ORCPT ); Sun, 6 Oct 2019 13:34:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D17FF2087E; Sun, 6 Oct 2019 17:34:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570383265; bh=ian+tWN6G0IstqirvWiqzGhkZLYP1MXNMkLKu3P74B8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T9qd5cwCyGZT3SX96pVwh9Rf2Tj2rL4Sx4GhoMwQZ/15iveJTNm+3gLPntsgdaQOj jGFvWXZVAuUuClRmvF/Ec8Ky5wTDLDszdaDpfa+rcNwza5dCvFScogzrzkiLy3EkGt I+XpSD4Hf9VqGA7HSb47bxXOTTIWc+0fQQV8w5W4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , "David S. Miller" Subject: [PATCH 5.2 007/137] net: qlogic: Fix memory leak in ql_alloc_large_buffers Date: Sun, 6 Oct 2019 19:19:51 +0200 Message-Id: <20191006171210.192543155@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006171209.403038733@linuxfoundation.org> References: <20191006171209.403038733@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost [ Upstream commit 1acb8f2a7a9f10543868ddd737e37424d5c36cf4 ] In ql_alloc_large_buffers, a new skb is allocated via netdev_alloc_skb. This skb should be released if pci_dma_mapping_error fails. Fixes: 0f8ab89e825f ("qla3xxx: Check return code from pci_map_single() in ql_release_to_lrg_buf_free_list(), ql_populate_free_queue(), ql_alloc_large_buffers(), and ql3xxx_send()") Signed-off-by: Navid Emamdoost Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qlogic/qla3xxx.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ethernet/qlogic/qla3xxx.c +++ b/drivers/net/ethernet/qlogic/qla3xxx.c @@ -2787,6 +2787,7 @@ static int ql_alloc_large_buffers(struct netdev_err(qdev->ndev, "PCI mapping failed with error: %d\n", err); + dev_kfree_skb_irq(skb); ql_free_large_buffers(qdev); return -ENOMEM; }