From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C76C4360C for ; Sun, 6 Oct 2019 17:25:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5020920867 for ; Sun, 6 Oct 2019 17:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570382707; bh=hpE6EBFLQyLMUQrjkG8l6mH4CF7Sr3JcameIFPSw3pA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=O+AM7lckDpdpF1nLrUj8+BEV8fHoAGdRStvU344Qei6KxrHjUuDA7cMBNYsjACeln bIJRqJpw4ISbmcz66VjZ2TNbUHM3lsvxnerk0ZYW/UsAf2TzXnFWpBiFBH2JaSc9bo E2OPvwIo4zL93jstYfD0xSTsjMRmp3074Dhi7300= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727506AbfJFRZG (ORCPT ); Sun, 6 Oct 2019 13:25:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:50030 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727297AbfJFRZB (ORCPT ); Sun, 6 Oct 2019 13:25:01 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 738CF2077B; Sun, 6 Oct 2019 17:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570382701; bh=hpE6EBFLQyLMUQrjkG8l6mH4CF7Sr3JcameIFPSw3pA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FBZFfZBewU7HbjL9pHbXzlx9v7bXNhX+h92/GiNVuoj0D0WvIt2TJyPpvWSyu2puI 4tQBTBA5upZS60zPSDKjk00F4SO1aEdlmtKGV7ODJMnDN9o+XfBtoHfXY8ZSyLeZ81 qvSGtS6CQGuce8/er5824RHRXuSWSrGq9Op0bfvE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , "David S. Miller" Subject: [PATCH 4.9 36/47] net: qlogic: Fix memory leak in ql_alloc_large_buffers Date: Sun, 6 Oct 2019 19:21:23 +0200 Message-Id: <20191006172018.794229150@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006172016.873463083@linuxfoundation.org> References: <20191006172016.873463083@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost [ Upstream commit 1acb8f2a7a9f10543868ddd737e37424d5c36cf4 ] In ql_alloc_large_buffers, a new skb is allocated via netdev_alloc_skb. This skb should be released if pci_dma_mapping_error fails. Fixes: 0f8ab89e825f ("qla3xxx: Check return code from pci_map_single() in ql_release_to_lrg_buf_free_list(), ql_populate_free_queue(), ql_alloc_large_buffers(), and ql3xxx_send()") Signed-off-by: Navid Emamdoost Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qlogic/qla3xxx.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ethernet/qlogic/qla3xxx.c +++ b/drivers/net/ethernet/qlogic/qla3xxx.c @@ -2783,6 +2783,7 @@ static int ql_alloc_large_buffers(struct netdev_err(qdev->ndev, "PCI mapping failed with error: %d\n", err); + dev_kfree_skb_irq(skb); ql_free_large_buffers(qdev); return -ENOMEM; }