From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F249EC4360C for ; Sun, 6 Oct 2019 17:24:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDD0E20867 for ; Sun, 6 Oct 2019 17:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570382690; bh=ezbkdOij8H/eXqwrs3/HxM1hHXVRSR/KKB0D+kPZAuM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=UF/xqddclGWyPKON8a2mao9o2nwtY11YpFWi2WijebCWAvThUEQQKXv/hJ33UFgrD dJKVJtitVOpujqNBUB1pVE85s/tErNJmNc9I9YvoXVgmCWKhOXr7DSDQgSMByukaGC eN6XFxrh3cOEoUcAtd5XbS4i0MlWq8K6nuLm8dkE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727448AbfJFRYt (ORCPT ); Sun, 6 Oct 2019 13:24:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:49744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727446AbfJFRYr (ORCPT ); Sun, 6 Oct 2019 13:24:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 087BA2133F; Sun, 6 Oct 2019 17:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570382686; bh=ezbkdOij8H/eXqwrs3/HxM1hHXVRSR/KKB0D+kPZAuM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mMie1lrS3+2nnqkjGFsaCq1maPEfpIbYr0gHDPZmPqhME32iu7M0ZE8cnTNinl6U4 Qkn6S3y7Obxg8tA4WDawTb4QwvHwtPyuyW9eDhxs76M/aO3KfLLnsP2PFQR4DjMnAW b1dYoXNiH5kMgC4b43MEabz42HgK2X87PbUrWshg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dotan Barak , Sudhakar Dindukurti , Santosh Shilimkar , "David S. Miller" Subject: [PATCH 4.9 41/47] net/rds: Fix error handling in rds_ib_add_one() Date: Sun, 6 Oct 2019 19:21:28 +0200 Message-Id: <20191006172019.053341501@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191006172016.873463083@linuxfoundation.org> References: <20191006172016.873463083@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dotan Barak [ Upstream commit d64bf89a75b65f83f06be9fb8f978e60d53752db ] rds_ibdev:ipaddr_list and rds_ibdev:conn_list are initialized after allocation some resources such as protection domain. If allocation of such resources fail, then these uninitialized variables are accessed in rds_ib_dev_free() in failure path. This can potentially crash the system. The code has been updated to initialize these variables very early in the function. Signed-off-by: Dotan Barak Signed-off-by: Sudhakar Dindukurti Acked-by: Santosh Shilimkar Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/rds/ib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/net/rds/ib.c +++ b/net/rds/ib.c @@ -138,6 +138,9 @@ static void rds_ib_add_one(struct ib_dev atomic_set(&rds_ibdev->refcount, 1); INIT_WORK(&rds_ibdev->free_work, rds_ib_dev_free); + INIT_LIST_HEAD(&rds_ibdev->ipaddr_list); + INIT_LIST_HEAD(&rds_ibdev->conn_list); + rds_ibdev->max_wrs = device->attrs.max_qp_wr; rds_ibdev->max_sge = min(device->attrs.max_sge, RDS_IB_MAX_SGE); @@ -189,9 +192,6 @@ static void rds_ib_add_one(struct ib_dev device->name, rds_ibdev->use_fastreg ? "FRMR" : "FMR"); - INIT_LIST_HEAD(&rds_ibdev->ipaddr_list); - INIT_LIST_HEAD(&rds_ibdev->conn_list); - down_write(&rds_ib_devices_lock); list_add_tail_rcu(&rds_ibdev->list, &rds_ib_devices); up_write(&rds_ib_devices_lock);