* [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning
@ 2019-10-06 18:49 Jules Irenge
2019-10-06 19:07 ` Greg KH
2019-10-06 21:31 ` [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning Al Viro
0 siblings, 2 replies; 6+ messages in thread
From: Jules Irenge @ 2019-10-06 18:49 UTC (permalink / raw)
To: outreachy-kernel
Cc: gregkh, linux-kernel, devel, olsonse, hsweeten, abbotti, Jules Irenge
Capitalize RANGE_mA to fix camelcase check warning.
Issue reported by checkpatch.pl
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/comedi/comedidev.h | 2 +-
drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++--
drivers/staging/comedi/drivers/dac02.c | 2 +-
drivers/staging/comedi/range.c | 6 +++---
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 54c091866777..2fc536db203c 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -603,7 +603,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
#define RANGE(a, b) {(a) * 1e6, (b) * 1e6, 0}
#define RANGE_ext(a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
-#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
+#define RANGE_MA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
#define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
#define BIP_RANGE(a) {-(a) * 1e6, (a) * 1e6, 0}
#define UNI_RANGE(a) {0, (a) * 1e6, 0}
diff --git a/drivers/staging/comedi/drivers/adv_pci1724.c b/drivers/staging/comedi/drivers/adv_pci1724.c
index e8ab573c839f..f20d710c19d3 100644
--- a/drivers/staging/comedi/drivers/adv_pci1724.c
+++ b/drivers/staging/comedi/drivers/adv_pci1724.c
@@ -64,8 +64,8 @@
static const struct comedi_lrange adv_pci1724_ao_ranges = {
4, {
BIP_RANGE(10),
- RANGE_mA(0, 20),
- RANGE_mA(4, 20),
+ RANGE_MA(0, 20),
+ RANGE_MA(4, 20),
RANGE_unitless(0, 1)
}
};
diff --git a/drivers/staging/comedi/drivers/dac02.c b/drivers/staging/comedi/drivers/dac02.c
index 5ef8114c2c85..4503cbdf673c 100644
--- a/drivers/staging/comedi/drivers/dac02.c
+++ b/drivers/staging/comedi/drivers/dac02.c
@@ -54,7 +54,7 @@ static const struct comedi_lrange das02_ao_ranges = {
UNI_RANGE(10),
BIP_RANGE(5),
BIP_RANGE(10),
- RANGE_mA(4, 20),
+ RANGE_MA(4, 20),
RANGE_ext(0, 1)
}
};
diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index 89d599877445..dacdd7b6f1a0 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/comedi/range.c
@@ -23,11 +23,11 @@ const struct comedi_lrange range_unipolar5 = { 1, {UNI_RANGE(5)} };
EXPORT_SYMBOL_GPL(range_unipolar5);
const struct comedi_lrange range_unipolar2_5 = { 1, {UNI_RANGE(2.5)} };
EXPORT_SYMBOL_GPL(range_unipolar2_5);
-const struct comedi_lrange range_0_20mA = { 1, {RANGE_mA(0, 20)} };
+const struct comedi_lrange range_0_20mA = { 1, {RANGE_MA(0, 20)} };
EXPORT_SYMBOL_GPL(range_0_20mA);
-const struct comedi_lrange range_4_20mA = { 1, {RANGE_mA(4, 20)} };
+const struct comedi_lrange range_4_20mA = { 1, {RANGE_MA(4, 20)} };
EXPORT_SYMBOL_GPL(range_4_20mA);
-const struct comedi_lrange range_0_32mA = { 1, {RANGE_mA(0, 32)} };
+const struct comedi_lrange range_0_32mA = { 1, {RANGE_MA(0, 32)} };
EXPORT_SYMBOL_GPL(range_0_32mA);
const struct comedi_lrange range_unknown = { 1, {{0, 1000000, UNIT_none} } };
EXPORT_SYMBOL_GPL(range_unknown);
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning
2019-10-06 18:49 [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning Jules Irenge
@ 2019-10-06 19:07 ` Greg KH
2019-10-07 15:33 ` [PATCH] checkpatch: Improve ignoring CamelCase SI style variants like mA Joe Perches
2019-10-06 21:31 ` [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning Al Viro
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2019-10-06 19:07 UTC (permalink / raw)
To: Jules Irenge; +Cc: outreachy-kernel, devel, linux-kernel, abbotti, olsonse
On Sun, Oct 06, 2019 at 07:49:03PM +0100, Jules Irenge wrote:
> Capitalize RANGE_mA to fix camelcase check warning.
> Issue reported by checkpatch.pl
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h | 2 +-
> drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++--
> drivers/staging/comedi/drivers/dac02.c | 2 +-
> drivers/staging/comedi/range.c | 6 +++---
> 4 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 54c091866777..2fc536db203c 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -603,7 +603,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
>
> #define RANGE(a, b) {(a) * 1e6, (b) * 1e6, 0}
> #define RANGE_ext(a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
> -#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
> +#define RANGE_MA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
Did you send this patch twice?
Anyway, this is the units "mA", which needs to be "mA" for obvious
reasons. Sorry, checkpatch is wrong in thsi case.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning
2019-10-06 18:49 [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning Jules Irenge
2019-10-06 19:07 ` Greg KH
@ 2019-10-06 21:31 ` Al Viro
1 sibling, 0 replies; 6+ messages in thread
From: Al Viro @ 2019-10-06 21:31 UTC (permalink / raw)
To: Jules Irenge
Cc: outreachy-kernel, gregkh, linux-kernel, devel, olsonse, hsweeten,
abbotti
On Sun, Oct 06, 2019 at 07:49:03PM +0100, Jules Irenge wrote:
[mA vs. MA]
Table 5. SI prefixes
Factor Name Symbol
....
10^6 mega M
....
10^-3 milli m
Confusing one for another (especially for electrical units) can be...
spectacular. FYI, 1mA is more or less what you get if you lick
the terminals of a 9V battery; 1MA is about 30 times the current
in typical lightning strike...
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] checkpatch: Improve ignoring CamelCase SI style variants like mA
2019-10-06 19:07 ` Greg KH
@ 2019-10-07 15:33 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2019-10-07 15:33 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Greg KH, Jules Irenge, Al Viro
Ignore all upper-case variants before and after SI units like
mA, mV and uV so uses like RANGE_mA do not emit a CAMELCASE message.
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/checkpatch.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index cf7543a9d1b2..edd20f7fa83c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5044,8 +5044,9 @@ sub process {
$var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
#Ignore Page<foo> variants
$var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
-#Ignore SI style variants like nS, mV and dB (ie: max_uV, regulator_min_uA_show)
- $var !~ /^(?:[a-z_]*?)_?[a-z][A-Z](?:_[a-z_]+)?$/ &&
+#Ignore SI style variants like nS, mV and dB
+#(ie: max_uV, regulator_min_uA_show, RANGE_mA_VALUE)
+ $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ &&
#Ignore some three character SI units explicitly, like MiB and KHz
$var !~ /^(?:[a-z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz)(?:_[a-z_]+)?$/) {
while ($var =~ m{($Ident)}g) {
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning
@ 2019-10-06 18:48 Jules Irenge
0 siblings, 0 replies; 6+ messages in thread
From: Jules Irenge @ 2019-10-06 18:48 UTC (permalink / raw)
To: outreachy-kernel
Cc: gregkh, linux-kernel, devel, olsonse, hsweeten, abbotti, Jules Irenge
Capitalize RANGE_mA to fix camelcase check warning.
Issue reported by checkpatch.pl
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/comedi/comedidev.h | 2 +-
drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++--
drivers/staging/comedi/drivers/dac02.c | 2 +-
drivers/staging/comedi/range.c | 6 +++---
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 54c091866777..2fc536db203c 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -603,7 +603,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
#define RANGE(a, b) {(a) * 1e6, (b) * 1e6, 0}
#define RANGE_ext(a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
-#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
+#define RANGE_MA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
#define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
#define BIP_RANGE(a) {-(a) * 1e6, (a) * 1e6, 0}
#define UNI_RANGE(a) {0, (a) * 1e6, 0}
diff --git a/drivers/staging/comedi/drivers/adv_pci1724.c b/drivers/staging/comedi/drivers/adv_pci1724.c
index e8ab573c839f..f20d710c19d3 100644
--- a/drivers/staging/comedi/drivers/adv_pci1724.c
+++ b/drivers/staging/comedi/drivers/adv_pci1724.c
@@ -64,8 +64,8 @@
static const struct comedi_lrange adv_pci1724_ao_ranges = {
4, {
BIP_RANGE(10),
- RANGE_mA(0, 20),
- RANGE_mA(4, 20),
+ RANGE_MA(0, 20),
+ RANGE_MA(4, 20),
RANGE_unitless(0, 1)
}
};
diff --git a/drivers/staging/comedi/drivers/dac02.c b/drivers/staging/comedi/drivers/dac02.c
index 5ef8114c2c85..4503cbdf673c 100644
--- a/drivers/staging/comedi/drivers/dac02.c
+++ b/drivers/staging/comedi/drivers/dac02.c
@@ -54,7 +54,7 @@ static const struct comedi_lrange das02_ao_ranges = {
UNI_RANGE(10),
BIP_RANGE(5),
BIP_RANGE(10),
- RANGE_mA(4, 20),
+ RANGE_MA(4, 20),
RANGE_ext(0, 1)
}
};
diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index 89d599877445..dacdd7b6f1a0 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/comedi/range.c
@@ -23,11 +23,11 @@ const struct comedi_lrange range_unipolar5 = { 1, {UNI_RANGE(5)} };
EXPORT_SYMBOL_GPL(range_unipolar5);
const struct comedi_lrange range_unipolar2_5 = { 1, {UNI_RANGE(2.5)} };
EXPORT_SYMBOL_GPL(range_unipolar2_5);
-const struct comedi_lrange range_0_20mA = { 1, {RANGE_mA(0, 20)} };
+const struct comedi_lrange range_0_20mA = { 1, {RANGE_MA(0, 20)} };
EXPORT_SYMBOL_GPL(range_0_20mA);
-const struct comedi_lrange range_4_20mA = { 1, {RANGE_mA(4, 20)} };
+const struct comedi_lrange range_4_20mA = { 1, {RANGE_MA(4, 20)} };
EXPORT_SYMBOL_GPL(range_4_20mA);
-const struct comedi_lrange range_0_32mA = { 1, {RANGE_mA(0, 32)} };
+const struct comedi_lrange range_0_32mA = { 1, {RANGE_MA(0, 32)} };
EXPORT_SYMBOL_GPL(range_0_32mA);
const struct comedi_lrange range_unknown = { 1, {{0, 1000000, UNIT_none} } };
EXPORT_SYMBOL_GPL(range_unknown);
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning
@ 2019-10-06 18:45 Jules Irenge
0 siblings, 0 replies; 6+ messages in thread
From: Jules Irenge @ 2019-10-06 18:45 UTC (permalink / raw)
To: outreachy
Cc: gregkh, linux-kernel, devel, olsonse, hsweeten, abbotti, Jules Irenge
Capitalize RANGE_mA to fix camelcase check warning.
Issue reported by checkpatch.pl
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/comedi/comedidev.h | 2 +-
drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++--
drivers/staging/comedi/drivers/dac02.c | 2 +-
drivers/staging/comedi/range.c | 6 +++---
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 54c091866777..2fc536db203c 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -603,7 +603,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
#define RANGE(a, b) {(a) * 1e6, (b) * 1e6, 0}
#define RANGE_ext(a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
-#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
+#define RANGE_MA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
#define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
#define BIP_RANGE(a) {-(a) * 1e6, (a) * 1e6, 0}
#define UNI_RANGE(a) {0, (a) * 1e6, 0}
diff --git a/drivers/staging/comedi/drivers/adv_pci1724.c b/drivers/staging/comedi/drivers/adv_pci1724.c
index e8ab573c839f..f20d710c19d3 100644
--- a/drivers/staging/comedi/drivers/adv_pci1724.c
+++ b/drivers/staging/comedi/drivers/adv_pci1724.c
@@ -64,8 +64,8 @@
static const struct comedi_lrange adv_pci1724_ao_ranges = {
4, {
BIP_RANGE(10),
- RANGE_mA(0, 20),
- RANGE_mA(4, 20),
+ RANGE_MA(0, 20),
+ RANGE_MA(4, 20),
RANGE_unitless(0, 1)
}
};
diff --git a/drivers/staging/comedi/drivers/dac02.c b/drivers/staging/comedi/drivers/dac02.c
index 5ef8114c2c85..4503cbdf673c 100644
--- a/drivers/staging/comedi/drivers/dac02.c
+++ b/drivers/staging/comedi/drivers/dac02.c
@@ -54,7 +54,7 @@ static const struct comedi_lrange das02_ao_ranges = {
UNI_RANGE(10),
BIP_RANGE(5),
BIP_RANGE(10),
- RANGE_mA(4, 20),
+ RANGE_MA(4, 20),
RANGE_ext(0, 1)
}
};
diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c
index 89d599877445..dacdd7b6f1a0 100644
--- a/drivers/staging/comedi/range.c
+++ b/drivers/staging/comedi/range.c
@@ -23,11 +23,11 @@ const struct comedi_lrange range_unipolar5 = { 1, {UNI_RANGE(5)} };
EXPORT_SYMBOL_GPL(range_unipolar5);
const struct comedi_lrange range_unipolar2_5 = { 1, {UNI_RANGE(2.5)} };
EXPORT_SYMBOL_GPL(range_unipolar2_5);
-const struct comedi_lrange range_0_20mA = { 1, {RANGE_mA(0, 20)} };
+const struct comedi_lrange range_0_20mA = { 1, {RANGE_MA(0, 20)} };
EXPORT_SYMBOL_GPL(range_0_20mA);
-const struct comedi_lrange range_4_20mA = { 1, {RANGE_mA(4, 20)} };
+const struct comedi_lrange range_4_20mA = { 1, {RANGE_MA(4, 20)} };
EXPORT_SYMBOL_GPL(range_4_20mA);
-const struct comedi_lrange range_0_32mA = { 1, {RANGE_mA(0, 32)} };
+const struct comedi_lrange range_0_32mA = { 1, {RANGE_MA(0, 32)} };
EXPORT_SYMBOL_GPL(range_0_32mA);
const struct comedi_lrange range_unknown = { 1, {{0, 1000000, UNIT_none} } };
EXPORT_SYMBOL_GPL(range_unknown);
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-07 15:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-06 18:49 [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning Jules Irenge
2019-10-06 19:07 ` Greg KH
2019-10-07 15:33 ` [PATCH] checkpatch: Improve ignoring CamelCase SI style variants like mA Joe Perches
2019-10-06 21:31 ` [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning Al Viro
-- strict thread matches above, loose matches on Subject: below --
2019-10-06 18:48 Jules Irenge
2019-10-06 18:45 Jules Irenge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).