* [PATCH] net: hns3: make array tick_array static, makes object smaller
@ 2019-10-07 11:09 Colin King
2019-10-07 14:01 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-10-07 11:09 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta, David S . Miller, Huazhong Tan,
Yunsheng Lin, Peng Li, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the array tick_array on the stack but instead make it
static. Makes the object code smaller by 29 bytes.
Before:
text data bss dec hex filename
19191 432 0 19623 4ca7 hisilicon/hns3/hns3pf/hclge_tm.o
After:
text data bss dec hex filename
19098 496 0 19594 4c8a hisilicon/hns3/hns3pf/hclge_tm.o
(gcc version 9.2.1, amd64)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
index 9f0e35f27789..5cce9b7f1d3d 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
@@ -46,7 +46,7 @@ static int hclge_shaper_para_calc(u32 ir, u8 shaper_level,
#define DIVISOR_CLK (1000 * 8)
#define DIVISOR_IR_B_126 (126 * DIVISOR_CLK)
- const u16 tick_array[HCLGE_SHAPER_LVL_CNT] = {
+ static const u16 tick_array[HCLGE_SHAPER_LVL_CNT] = {
6 * 256, /* Prioriy level */
6 * 32, /* Prioriy group level */
6 * 8, /* Port level */
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: hns3: make array tick_array static, makes object smaller
2019-10-07 11:09 [PATCH] net: hns3: make array tick_array static, makes object smaller Colin King
@ 2019-10-07 14:01 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-10-07 14:01 UTC (permalink / raw)
To: colin.king
Cc: yisen.zhuang, salil.mehta, tanhuazhong, linyunsheng, lipeng321,
netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Mon, 7 Oct 2019 12:09:35 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array tick_array on the stack but instead make it
> static. Makes the object code smaller by 29 bytes.
>
> Before:
> text data bss dec hex filename
> 19191 432 0 19623 4ca7 hisilicon/hns3/hns3pf/hclge_tm.o
>
> After:
> text data bss dec hex filename
> 19098 496 0 19594 4c8a hisilicon/hns3/hns3pf/hclge_tm.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-07 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-07 11:09 [PATCH] net: hns3: make array tick_array static, makes object smaller Colin King
2019-10-07 14:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).