From: "Michael S. Tsirkin" <mst@redhat.com>
To: jcfaracco@gmail.com
Cc: netdev@vger.kernel.org, jasowang@redhat.com, davem@davemloft.net,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, dnmendes76@gmail.com
Subject: Re: [PATCH RFC net-next 0/2] drivers: net: virtio_net: Implement
Date: Mon, 7 Oct 2019 03:43:50 -0400 [thread overview]
Message-ID: <20191007034208-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20191006184515.23048-1-jcfaracco@gmail.com>
On Sun, Oct 06, 2019 at 03:45:13PM -0300, jcfaracco@gmail.com wrote:
> From: Julio Faracco <jcfaracco@gmail.com>
>
> Driver virtio_net is not handling error events for TX provided by
> dev_watchdog. This event is reached when transmission queue is having
> problems to transmit packets. To enable it, driver should have
> .ndo_tx_timeout implemented. This serie has two commits:
>
> In the past, we implemented a function to recover driver state when this
> kind of event happens, but the structure was to complex for virtio_net
> that moment.
It's more that it was missing a bunch of locks.
> Alternativelly, this skeleton should be enough for now.
>
> For further details, see thread:
> https://lkml.org/lkml/2015/6/23/691
>
> Patch 1/2:
> Add statistic field for TX timeout events.
>
> Patch 2/2:
> Implement a skeleton function to debug TX timeout events.
>
> Julio Faracco (2):
> drivers: net: virtio_net: Add tx_timeout stats field
> drivers: net: virtio_net: Add tx_timeout function
>
> drivers/net/virtio_net.c | 33 ++++++++++++++++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> --
> 2.21.0
next prev parent reply other threads:[~2019-10-07 7:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 18:45 [PATCH RFC net-next 0/2] drivers: net: virtio_net: Implement jcfaracco
2019-10-06 18:45 ` [PATCH RFC net-next 1/2] drivers: net: virtio_net: Add tx_timeout stats field jcfaracco
2019-10-07 14:15 ` Julian Wiedmann
2019-10-07 14:55 ` Julio Faracco
2019-10-06 18:45 ` [PATCH RFC net-next 2/2] drivers: net: virtio_net: Add tx_timeout function jcfaracco
2019-10-07 7:51 ` Michael S. Tsirkin
2019-10-07 14:03 ` Julio Faracco
2019-10-07 16:03 ` Julio Faracco
2019-10-12 12:59 ` Jason Wang
2019-10-12 13:01 ` Jason Wang
2019-10-07 7:43 ` Michael S. Tsirkin [this message]
2019-10-07 13:58 ` [PATCH RFC net-next 0/2] drivers: net: virtio_net: Implement Julio Faracco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007034208-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=dnmendes76@gmail.com \
--cc=jasowang@redhat.com \
--cc=jcfaracco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).