From: Maxime Ripard <mripard@kernel.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Chen-Yu Tsai <wens@csie.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
michael@amarulasolutions.com, Icenowy Zheng <icenowy@aosc.io>,
linux-sunxi <linux-sunxi@googlegroups.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v10 5/6] arm64: dts: allwinner: a64: Add MIPI DSI pipeline
Date: Mon, 7 Oct 2019 12:57:08 +0200 [thread overview]
Message-ID: <20191007105708.raxavxk4n7bvxh7x@gilmour> (raw)
In-Reply-To: <20191005141913.22020-6-jagan@amarulasolutions.com>
[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]
On Sat, Oct 05, 2019 at 07:49:12PM +0530, Jagan Teki wrote:
> Add MIPI DSI pipeline for Allwinner A64.
>
> - dsi node, with A64 compatible since it doesn't support
> DSI_SCLK gating unlike A33
> - dphy node, with A64 compatible with A33 fallback since
> DPHY on A64 and A33 is similar
> - finally, attach the dsi_in to tcon0 for complete MIPI DSI
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Tested-by: Merlijn Wajer <merlijn@wizzup.org>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 69128a6dfc46..ad4170b8aee0 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -382,6 +382,12 @@
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <1>;
> +
> + tcon0_out_dsi: endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&dsi_in_tcon0>;
> + allwinner,tcon-channel = <1>;
> + };
> };
> };
> };
> @@ -1003,6 +1009,38 @@
> status = "disabled";
> };
>
> + dsi: dsi@1ca0000 {
> + compatible = "allwinner,sun50i-a64-mipi-dsi";
> + reg = <0x01ca0000 0x1000>;
> + interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&ccu CLK_BUS_MIPI_DSI>;
> + clock-names = "bus";
This won't validate with the bindings you have either here, since it
still expects bus and mod.
I guess in that cas, we can just drop clock-names, which will require
a bit of work on the driver side as well.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-10-07 10:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 14:19 [PATCH v10 0/6] drm/sun4i: Allwinner A64 MIPI-DSI support Jagan Teki
2019-10-05 14:19 ` [PATCH v10 1/6] dt-bindings: sun6i-dsi: Add A64 MIPI-DSI compatible Jagan Teki
2019-10-07 9:31 ` Maxime Ripard
2019-10-13 17:02 ` Jagan Teki
2019-10-14 11:00 ` Maxime Ripard
2019-10-05 14:19 ` [PATCH v10 2/6] dt-bindings: sun6i-dsi: Add A64 DPHY compatible (w/ A31 fallback) Jagan Teki
2019-10-05 14:19 ` [PATCH v10 3/6] drm/sun4i: dsi: Add has_mod_clk quirk Jagan Teki
2019-10-05 14:19 ` [PATCH v10 4/6] drm/sun4i: dsi: Add Allwinner A64 MIPI DSI support Jagan Teki
2019-10-05 14:19 ` [PATCH v10 5/6] arm64: dts: allwinner: a64: Add MIPI DSI pipeline Jagan Teki
2019-10-07 10:57 ` Maxime Ripard [this message]
2019-10-14 12:07 ` Jagan Teki
2019-10-16 8:03 ` Maxime Ripard
2019-10-16 8:49 ` Jagan Teki
2019-10-17 9:52 ` Maxime Ripard
2019-10-24 7:58 ` Jagan Teki
2019-10-24 18:27 ` Maxime Ripard
2019-10-25 13:23 ` Jagan Teki
2019-10-24 12:56 ` Jagan Teki
2019-10-24 18:28 ` Maxime Ripard
2019-10-05 14:19 ` [DO NOT MERGE] [PATCH v10 6/6] arm64: dts: allwinner: bananapi-m64: Enable Bananapi S070WV20-CT16 DSI panel Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007105708.raxavxk4n7bvxh7x@gilmour \
--to=mripard@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=jagan@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).