From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7578AECE58D for ; Mon, 7 Oct 2019 13:17:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CCF32084D for ; Mon, 7 Oct 2019 13:17:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728390AbfJGNRn (ORCPT ); Mon, 7 Oct 2019 09:17:43 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:55463 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727490AbfJGNRm (ORCPT ); Mon, 7 Oct 2019 09:17:42 -0400 X-Originating-IP: 86.207.98.53 Received: from localhost (aclermont-ferrand-651-1-259-53.w86-207.abo.wanadoo.fr [86.207.98.53]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id B7BFE1C001A; Mon, 7 Oct 2019 13:17:38 +0000 (UTC) Date: Mon, 7 Oct 2019 15:17:36 +0200 From: Alexandre Belloni To: Krzysztof Kozlowski Cc: Rob Herring , Mark Rutland , Kukjin Kim , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Sebastian Reichel , Alessandro Zummo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers Message-ID: <20191007131736.GJ4254@piout.net> References: <20191002160744.11307-1-krzk@kernel.org> <20191002160744.11307-2-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191002160744.11307-2-krzk@kernel.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/10/2019 18:07:42+0200, Krzysztof Kozlowski wrote: > Make the examples in S3C RTC bindings more readable and bring them > closer to real DTS by using defines for clocks. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Alexandre Belloni > --- > Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml > index 95570d7e19eb..4d91cdc9b998 100644 > --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml > @@ -75,11 +75,14 @@ allOf: > > examples: > - | > + #include > + #include > + > rtc@10070000 { > compatible = "samsung,s3c6410-rtc"; > reg = <0x10070000 0x100>; > interrupts = <0 44 4>, <0 45 4>; > - clocks = <&clock 0>, // CLK_RTC > - <&s2mps11_osc 0>; // S2MPS11_CLK_AP > + clocks = <&clock CLK_RTC>, > + <&s2mps11_osc S2MPS11_CLK_AP>; > clock-names = "rtc", "rtc_src"; > }; > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com