From: Jin Yao <yao.jin@linux.intel.com>
To: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com
Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com,
Jin Yao <yao.jin@linux.intel.com>
Subject: [PATCH v1 0/5] perf report: Support sorting all blocks by cycles
Date: Tue, 8 Oct 2019 15:04:57 +0800 [thread overview]
Message-ID: <20191008070502.22551-1-yao.jin@linux.intel.com> (raw)
It would be useful to support sorting for all blocks by the
sampled cycles percent per block. This is useful to concentrate
on the globally busiest/slowest blocks.
This patch series implements a new sort option "total_cycles" which
sorts all blocks by 'Sampled Cycles%'. The 'Sampled Cycles%' is
block sampled cycles aggregation / total sampled cycles
For example,
perf record -b ./div
perf report -s total_cycles --stdio
# To display the perf.data header info, please use --header/--header-only options.
#
#
# Total Lost Samples: 0
#
# Samples: 2M of event 'cycles'
# Event count (approx.): 2753248
#
# Sampled Cycles% Sampled Cycles Avg Cycles% Avg Cycles [Program Block Range] Shared Object
# ............... .............. ........... .......... ................................................................. ....................
#
26.04% 2.8M 0.40% 18 [div.c:42 -> div.c:39] div
15.17% 1.2M 0.16% 7 [random_r.c:357 -> random_r.c:380] libc-2.27.so
5.11% 402.0K 0.04% 2 [div.c:27 -> div.c:28] div
4.87% 381.6K 0.04% 2 [random.c:288 -> random.c:291] libc-2.27.so
4.53% 381.0K 0.04% 2 [div.c:40 -> div.c:40] div
3.85% 300.9K 0.02% 1 [div.c:22 -> div.c:25] div
3.08% 241.1K 0.02% 1 [rand.c:26 -> rand.c:27] libc-2.27.so
3.06% 240.0K 0.02% 1 [random.c:291 -> random.c:291] libc-2.27.so
2.78% 215.7K 0.02% 1 [random.c:298 -> random.c:298] libc-2.27.so
2.52% 198.3K 0.02% 1 [random.c:293 -> random.c:293] libc-2.27.so
2.36% 184.8K 0.02% 1 [rand.c:28 -> rand.c:28] libc-2.27.so
2.33% 180.5K 0.02% 1 [random.c:295 -> random.c:295] libc-2.27.so
2.28% 176.7K 0.02% 1 [random.c:295 -> random.c:295] libc-2.27.so
2.20% 168.8K 0.02% 1 [rand@plt+0 -> rand@plt+0] div
1.98% 158.2K 0.02% 1 [random_r.c:388 -> random_r.c:388] libc-2.27.so
1.57% 123.3K 0.02% 1 [div.c:42 -> div.c:44] div
1.44% 116.0K 0.42% 19 [random_r.c:357 -> random_r.c:394] libc-2.27.so
......
This patch series supports both stdio and tui. And also with the supporting
of --percent-limit.
Jin Yao (5):
perf util: Create new block.h/block.c for block related functions
perf util: Count the total cycles of all samples
perf report: Sort by sampled cycles percent per block for stdio
perf report: Support --percent-limit for total_cycles
perf report: Sort by sampled cycles percent per block for tui
tools/perf/Documentation/perf-report.txt | 10 +
tools/perf/builtin-annotate.c | 2 +-
tools/perf/builtin-diff.c | 41 +--
tools/perf/builtin-report.c | 445 ++++++++++++++++++++++-
tools/perf/builtin-top.c | 3 +-
tools/perf/ui/browsers/hists.c | 62 +++-
tools/perf/ui/browsers/hists.h | 2 +
tools/perf/ui/stdio/hist.c | 29 +-
tools/perf/util/Build | 1 +
tools/perf/util/block.c | 73 ++++
tools/perf/util/block.h | 39 ++
tools/perf/util/hist.c | 11 +-
tools/perf/util/hist.h | 15 +-
tools/perf/util/sort.c | 5 +
tools/perf/util/sort.h | 1 +
tools/perf/util/symbol.c | 22 --
tools/perf/util/symbol.h | 23 --
tools/perf/util/symbol_conf.h | 1 +
18 files changed, 693 insertions(+), 92 deletions(-)
create mode 100644 tools/perf/util/block.c
create mode 100644 tools/perf/util/block.h
--
2.17.1
next reply other threads:[~2019-10-08 7:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 7:04 Jin Yao [this message]
2019-10-08 7:04 ` [PATCH v1 1/5] perf util: Create new block.h/block.c for block related functions Jin Yao
2019-10-08 7:04 ` [PATCH v1 2/5] perf util: Count the total cycles of all samples Jin Yao
2019-10-08 7:05 ` [PATCH v1 3/5] perf report: Sort by sampled cycles percent per block for stdio Jin Yao
2019-10-08 7:05 ` [PATCH v1 4/5] perf report: Support --percent-limit for total_cycles Jin Yao
2019-10-08 7:05 ` [PATCH v1 5/5] perf report: Sort by sampled cycles percent per block for tui Jin Yao
2019-10-14 15:32 ` [PATCH v1 0/5] perf report: Support sorting all blocks by cycles Jiri Olsa
2019-10-15 2:00 ` Jin, Yao
2019-10-15 5:37 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008070502.22551-1-yao.jin@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).