From: Ludovic Desroches <ludovic.desroches@microchip.com>
To: Rob Herring <robh@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<ulf.hansson@linaro.org>, <nicolas.ferre@microchip.com>,
<adrian.hunter@intel.com>, <linux-kernel@vger.kernel.org>,
<mark.rutland@arm.com>, <claudiu.beznea@microchip.com>
Subject: Re: [PATCH 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties
Date: Tue, 8 Oct 2019 11:28:27 +0200 [thread overview]
Message-ID: <20191008092826.63kbia2wkggeab74@M43218.corp.atmel.com> (raw)
In-Reply-To: <20190930145613.GA11254@bogus>
On Mon, Sep 30, 2019 at 09:56:13AM -0500, Rob Herring wrote:
> On Thu, Sep 12, 2019 at 10:09:06PM +0200, Ludovic Desroches wrote:
> > There is a new compatible string for the SAM9X60 sdhci device. It involves
> > an update of the properties about the clocks stuff.
> >
> > Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> > ---
> > .../devicetree/bindings/mmc/sdhci-atmel.txt | 25 ++++++++++++++++---
> > 1 file changed, 22 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-atmel.txt b/Documentation/devicetree/bindings/mmc/sdhci-atmel.txt
> > index 1b662d7171a0..364ceea330b6 100644
> > --- a/Documentation/devicetree/bindings/mmc/sdhci-atmel.txt
> > +++ b/Documentation/devicetree/bindings/mmc/sdhci-atmel.txt
> > @@ -5,12 +5,19 @@ Documentation/devicetree/bindings/mmc/mmc.txt and the properties used by the
> > sdhci-of-at91 driver.
> >
> > Required properties:
> > -- compatible: Must be "atmel,sama5d2-sdhci".
> > +- compatible: Must be "atmel,sama5d2-sdhci" or "microchip,sam9x60-sdhci".
> > - clocks: Phandlers to the clocks.
> > -- clock-names: Must be "hclock", "multclk", "baseclk";
> > +- clock-names: Must be "hclock", "multclk", "baseclk" for
> > + "atmel,sama5d2-sdhci".
> > + Must be "hclock", "multclk" for "microchip,sam9x60-sdhci".
> >
> > +Optional properties:
> > +- assigned-clocks: The same with "multclk".
> > +- assigned-clock-rates The rate of "multclk" in order to not rely on the
> > + gck configuration set by previous components.
> >
> > -Example:
> > +
> > +Examples:
> >
> > sdmmc0: sdio-host@a0000000 {
> > compatible = "atmel,sama5d2-sdhci";
> > @@ -18,4 +25,16 @@ sdmmc0: sdio-host@a0000000 {
> > interrupts = <31 IRQ_TYPE_LEVEL_HIGH 0>;
> > clocks = <&sdmmc0_hclk>, <&sdmmc0_gclk>, <&main>;
> > clock-names = "hclock", "multclk", "baseclk";
> > + assigned-clocks = <&sdmmc0_gclk>;
> > + assigned-clock-rates = <480000000>;
> > +};
> > +
> > +sdmmc0: sdio-host@80000000 {
>
> mmc@...
>
> Though I don't see much value in a second example. Examples are not a
> complete enumeration of all possible dts entries.
>
Ok, I'll skip this example.
Ludovic
> > + compatible = "microchip,sam9x60-sdhci";
> > + reg = <0x80000000 0x300>;
> > + interrupts = <12 IRQ_TYPE_LEVEL_HIGH 0>;
> > + clocks = <&pmc PMC_TYPE_PERIPHERAL 12>, <&pmc PMC_TYPE_GCK 12>;
> > + clock-names = "hclock", "multclk";
> > + assigned-clocks = <&pmc PMC_TYPE_GCK 12>;
> > + assigned-clock-rates = <100000000>;
> > };
> > --
> > 2.23.0
> >
prev parent reply other threads:[~2019-10-08 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 20:09 [PATCH 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties Ludovic Desroches
2019-09-12 20:09 ` [PATCH 2/3] mmc: sdhci-of-at91: rework clocks management to support SAM9x60 device Ludovic Desroches
2019-09-20 9:34 ` Eugen.Hristev
2019-10-08 9:24 ` Ludovic Desroches
2019-09-12 20:09 ` [PATCH 3/3] ARM: dts: at91: sama5d2: set the sdmmc gclk frequency Ludovic Desroches
2019-09-30 14:56 ` [PATCH 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties Rob Herring
2019-10-08 9:28 ` Ludovic Desroches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008092826.63kbia2wkggeab74@M43218.corp.atmel.com \
--to=ludovic.desroches@microchip.com \
--cc=adrian.hunter@intel.com \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).