From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A16FFC10F14 for ; Tue, 8 Oct 2019 14:17:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 856DF20673 for ; Tue, 8 Oct 2019 14:17:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726852AbfJHORE (ORCPT ); Tue, 8 Oct 2019 10:17:04 -0400 Received: from muru.com ([72.249.23.125]:35954 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725795AbfJHORD (ORCPT ); Tue, 8 Oct 2019 10:17:03 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2FF498081; Tue, 8 Oct 2019 14:17:36 +0000 (UTC) Date: Tue, 8 Oct 2019 07:16:59 -0700 From: Tony Lindgren To: Graeme Smecher Cc: Andrey Smirnov , linux-omap@vger.kernel.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: am3874-iceboard: Fix 'i2c-mux-idle-disconnect' usage Message-ID: <20191008141659.GC5610@atomide.com> References: <20191004014548.29583-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Graeme Smecher [191004 23:53]: > Hi Andrey, > > On 2019-10-03 6:45 p.m., Andrey Smirnov wrote: > > According to > > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt, > > i2c-mux-idle-disconnect is a property of a parent node since it > > pertains to the mux/switch as a whole, so move it there and drop all > > of the concurrences in child nodes. > > > > Fixes: d031773169df ("ARM: dts: Adds device tree file for McGill's IceBoard, based on TI AM3874") > > Signed-off-by: Andrey Smirnov > > Cc: Benoît Cousson > > Cc: Tony Lindgren > > Cc: Graeme Smecher > > Cc: linux-omap@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > --- > > > > This is purely a drive-by fix, since it concerns the HW I've never > > heard of before. However I was working with PCA9548 > > (vf610-zii-scu4-aib is my HW) and looking at various users in the > > kernel, when this code caught my eye. Apologies for the noise if this > > fix is somehow bogus. > > > > In case that it matters this patch is based on top of 5.4-rc1. > > Thanks! We do have I2C address collisions on downstream bus segments, so > keeping these segments isolated is important. I'm surprised this patch > was necessary and happy to see it. > > Lightly tested on 5.3. > > Tested-by: Graeme Smecher Applying into fixes thanks. Tony