From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40621C10F14 for ; Tue, 8 Oct 2019 14:54:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 047EA20815 for ; Tue, 8 Oct 2019 14:54:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="ZgCY1LFp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726253AbfJHOy1 (ORCPT ); Tue, 8 Oct 2019 10:54:27 -0400 Received: from mail.skyhub.de ([5.9.137.197]:53638 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfJHOy0 (ORCPT ); Tue, 8 Oct 2019 10:54:26 -0400 Received: from zn.tnic (p200300EC2F0B5100B1AE7F6CCC5C3495.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:5100:b1ae:7f6c:cc5c:3495]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B289B1EC067D; Tue, 8 Oct 2019 16:54:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1570546465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=jWIuzLaCmNrAtkFpesn2+ymOitb9cF5jmTsz8H7LDk0=; b=ZgCY1LFprAshcWzMhuDWe3mn/94VhdlBngLvkIslTztBmQySHkKlv2YoSb6IHc71iJDCdA ReBjP05rKjcS1MLsehpTaJSTB+05IoQnjFj4VaKnH/jhK6Tarzdswb36ZOPHGQyXRLl28b 08YexrgmrvetN4fp/RbjAtNUor8pskc= Date: Tue, 8 Oct 2019 16:54:24 +0200 From: Borislav Petkov To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, bristot@redhat.com, jbaron@akamai.com, torvalds@linux-foundation.org, tglx@linutronix.de, mingo@kernel.org, namit@vmware.com, hpa@zytor.com, luto@kernel.org, ard.biesheuvel@linaro.org, jpoimboe@redhat.com Subject: Re: [PATCH v3 1/6] x86/alternatives: Teach text_poke_bp() to emulate instructions Message-ID: <20191008145423.GG14765@zn.tnic> References: <20191007081716.07616230.8@infradead.org> <20191007081944.88332264.2@infradead.org> <20191008142924.GE14765@zn.tnic> <20191008144834.GD2328@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191008144834.GD2328@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 08, 2019 at 04:48:34PM +0200, Peter Zijlstra wrote: > Can, but why? That's more lines for no raisin ;-) Here's a raisin: I was looking at this and then all of a sudden went: "W00t, why is this do_sync part of the loop at all? Do they belong together? Nope." If we're going to save on lines, we've lost long ago. > Very first pass, we write INT3's everywhere. Doh. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette