From: Stephen Boyd <swboyd@chromium.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>,
Evan Green <evgreen@chromium.org>
Subject: [PATCH v2 0/2] Avoid regmap debugfs collisions in qcom llcc driver
Date: Tue, 8 Oct 2019 16:45:03 -0700 [thread overview]
Message-ID: <20191008234505.222991-1-swboyd@chromium.org> (raw)
Now a two part series. These patches fix a debugfs name collision for
the llcc regmaps and moves the config to a local variable to save on
image size.
Changes from v1 (https://lkml.kernel.org/r/20191004233132.194336-1-swboyd@chromium.org):
* New second patch
* Dropped static
* See range-diff below!
Stephen Boyd (2):
soc: qcom: llcc: Name regmaps to avoid collisions
soc: qcom: llcc: Move regmap config to local variable
drivers/soc/qcom/llcc-slice.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
Cc: Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>
Cc: Evan Green <evgreen@chromium.org>
Range-diff against v1:
-: ------------ > 1: 07bc0e8bdb6e soc: qcom: llcc: Name regmaps to avoid collisions
1: 0c54fc8a7ed6 ! 2: 5c4446e36783 soc: qcom: llcc: Name regmaps to avoid collisions
@@ Metadata
Author: Stephen Boyd <swboyd@chromium.org>
## Commit message ##
- soc: qcom: llcc: Name regmaps to avoid collisions
+ soc: qcom: llcc: Move regmap config to local variable
- We'll end up with debugfs collisions if we don't give names to the
- regmaps created inside this driver. Copy the template config over into
- this function and give the regmap the same name as the resource name.
+ This is now a global variable that we're modifying to fix the name.
+ That isn't terribly thread safe and it's not necessary to be a global so
+ let's just move this to a local variable instead. This saves space in
+ the symtab and actually reduces kernel image size because the regmap
+ config is large and we can replace the initialization of that structure
+ with a memset and a few member assignments.
- Fixes: 7f9c136216c7 ("soc: qcom: Add broadcast base for Last Level Cache Controller (LLCC)")
- Cc: Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>
- Cc: Evan Green <evgreen@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
## drivers/soc/qcom/llcc-slice.c ##
@@ drivers/soc/qcom/llcc-slice.c
static struct llcc_drv_data *drv_data = (void *) -EPROBE_DEFER;
--static const struct regmap_config llcc_regmap_config = {
+-static struct regmap_config llcc_regmap_config = {
- .reg_bits = 32,
- .reg_stride = 4,
- .val_bits = 32,
@@ drivers/soc/qcom/llcc-slice.c: static struct regmap *qcom_llcc_init_mmio(struct
{
struct resource *res;
void __iomem *base;
-+ static struct regmap_config llcc_regmap_config = {
++ struct regmap_config llcc_regmap_config = {
+ .reg_bits = 32,
+ .reg_stride = 4,
+ .val_bits = 32,
@@ drivers/soc/qcom/llcc-slice.c: static struct regmap *qcom_llcc_init_mmio(struct
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);
if (!res)
-@@ drivers/soc/qcom/llcc-slice.c: static struct regmap *qcom_llcc_init_mmio(struct platform_device *pdev,
- if (IS_ERR(base))
- return ERR_CAST(base);
-
-+ llcc_regmap_config.name = name;
- return devm_regmap_init_mmio(&pdev->dev, base, &llcc_regmap_config);
- }
-
base-commit: 8b0eed9f6e36a5488967b0acc51444d658dd711b
--
Sent by a computer through tubes
next reply other threads:[~2019-10-08 23:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 23:45 Stephen Boyd [this message]
2019-10-08 23:45 ` [PATCH v2 1/2] soc: qcom: llcc: Name regmaps to avoid collisions Stephen Boyd
2019-10-09 15:25 ` Evan Green
2019-10-08 23:45 ` [PATCH v2 2/2] soc: qcom: llcc: Move regmap config to local variable Stephen Boyd
2019-10-08 23:55 ` [PATCH v2 0/2] Avoid regmap debugfs collisions in qcom llcc driver Bjorn Andersson
2019-10-09 1:58 ` Stephen Boyd
2019-10-09 16:01 ` Evan Green
2019-10-09 17:46 ` Bjorn Andersson
2019-10-09 17:59 ` Evan Green
2019-10-10 3:57 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008234505.222991-1-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vnkgutta@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).