From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F6DFC47404 for ; Wed, 9 Oct 2019 08:24:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FD112133F for ; Wed, 9 Oct 2019 08:24:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ZmLP9UMQ"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="KNXveYci" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729882AbfJIIYH (ORCPT ); Wed, 9 Oct 2019 04:24:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56998 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbfJIIYG (ORCPT ); Wed, 9 Oct 2019 04:24:06 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7B18A61A81; Wed, 9 Oct 2019 08:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570609445; bh=gk+Iu3xI3mpVS78D5WgnLWyU9HVaeDM2lRyYaVDJTak=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=ZmLP9UMQn8H42q9iRFGBKy9XCPOjknjcn7beaP7LxwUuuCLrVPHT0LypyGjkXh64w XfsSdFkzI6V+qYVNdr7RygMgluvYKAh0iHNFUlq0JYQYJW9v39kndlnGNMHfBZ1iix rgXdByohYBO3TLNeTdOVZKD7A5X+eTq6QfvzMDV8= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id BEADE60AD1; Wed, 9 Oct 2019 08:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570609444; bh=gk+Iu3xI3mpVS78D5WgnLWyU9HVaeDM2lRyYaVDJTak=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=KNXveYciZj7X5Zel1mmXX5dfsFwHj2PDoaOwfT49Bo/zQXv2NHTwpaZsMpJMtfHuU Yj1XG6auay5q8enHbq/i4ZSMUy+NoAyaXuWo8Yf9QEnW06fFnqgMDh2IJA4PRmbrP6 AOou5NilrSGAxXkVDsohp3W8z1ySzFP/ntkDTouo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BEADE60AD1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/2] Revert "rsi: fix potential null dereference in rsi_probe()" From: Kalle Valo In-Reply-To: <20191004144422.13003-1-johan@kernel.org> References: <20191004144422.13003-1-johan@kernel.org> To: Johan Hovold Cc: Amitkumar Karwar , Siva Rebbagondla , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Denis Efremov , Johan Hovold User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191009082405.7B18A61A81@smtp.codeaurora.org> Date: Wed, 9 Oct 2019 08:24:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johan Hovold wrote: > This reverts commit f170d44bc4ec2feae5f6206980e7ae7fbf0432a0. > > USB core will never call a USB-driver probe function with a NULL > device-id pointer. > > Reverting before removing the existing checks in order to document this > and prevent the offending commit from being "autoselected" for stable. > > Signed-off-by: Johan Hovold 2 patches applied to wireless-drivers-next.git, thanks. c5dcf8f0e850 Revert "rsi: fix potential null dereference in rsi_probe()" 39e50f5ce26c rsi: drop bogus device-id checks from probe -- https://patchwork.kernel.org/patch/11174711/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches